-
Notifications
You must be signed in to change notification settings - Fork 846
Fix export bug: missing data/columns (A sort of Revert of #28678) #29448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y to merge all the columns/exported data
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
|
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run to get started. More details: p9dueE-5Nn-p2 |
|
Pushed 3d80139 with update to tests in package and module |
oskosk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…9448) Co-authored-by: oskosk <[email protected]>
|
This has been cherry picked to the release branch and a special package v0.6.0.2 has been cut to be included in 11.9.1 |


A bug was found when exporting form responses. The bug was introduced on #28678 and/or #28425 in the spirit of making column names look better by removing the order prefix. This led to wrong data merging upon the export process.
Fixes #29429
Proposed changes:
This PR rolls back the rename/cleanup of field names (columns) to leave them as they were before the mentioned PRs. This doesn't mean we're completely reverting those changes, as all the other improvements remain.
Other information:
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Follow instructions on #29429
Exported data should now reflect the collected data more faithfully, even if that means that the same 2 fields are treated as different ones after inverting their order. This has always behaved that way and we plan to improve it on further iterations.