Revert "Show social review prompt with both Social and Jetpack installed"

[spsiddarthan]

Reverts #29910

We are going to revert this PR to fix the initial state of the plugin p1681469685034749-slack-C02JJ910CNL and pick up 1198218726984184-as-1204393860935466 in the following sprints. The social plugin will have the review prompts working when it's active. The review prompts won't show up when both Social and Jetpack are active.

This is the #27917 which originally added the review prompts. But this line sets the state for the Social plugin only if the Jetpack plugin is not active which leads to #29910 being created, I presume. That accidentally stomped over the plugin's initial state.

Does this pull request change what data or activity we track or use?

• Yes, this PR reinstates 3 new analytics events around the new review prompt:

• jetpack_social_plugin_review_prompt_view (recorded when review prompt is rendered)
• jetpack_social_plugin_review_prompt_new_review_click (recorded when "Leave a review" is clicked)
• jetpack_social_plugin_review_prompt_dismiss_click (recorded when "Dismissed" is clicked)

Testing instructions:

• When the prompt renders, the jetpack_social_plugin_review_prompt_view analytics event should fire. Search for this in your browser's network panel to confirm.
• Confirm that clicking on "Leave a Review" takes you to the reviews page for the Jetpack Social plugin
• Create another new post, but disable sharing. No prompt will show up since sharing was disabled.
• Publish a post again, but disable the individual connections. Make sure the prompts don't show up.
• Publish a post again with sharing enabled and notice that the prompt shows up. Dismiss the prompt
• Publish a post again with sharing enabled and notice that no prompt shows up.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Social plugin:

• Next scheduled release: May 2, 2023.
• Scheduled code freeze: April 24, 2023.

[danielpost]

@spsiddarthan I created a new site to test this. Connected Social, added an account and published a new post. Instead of the prompt I got an empty panel (see screenshot). Any idea what might cause this?

[spsiddarthan]

Any idea what might cause this?

I'll have to check that, Daniel! Will get back.

[pablinos]

Instead of the prompt I got an empty panel (see screenshot). Any idea what might cause this?

If that was with Jetpack Social rather than Jetpack then I think that's the problem the original PR was trying to fix. Maybe we should fix it rather than reverting it.

[pablinos]

The empty panel comes from here. showNotices is false causing an empty panel to be rendered. I'm not sure why we don't get one in the pre-publish sidebar, but the problem doesn't seem related to this PR.

[pablinos]

This is working well for me. It reverts the changes, and the review prompt is still displayed when Social is active, but not Jetpack.

[spsiddarthan]

If that was with Jetpack Social rather than Jetpack then I think that's the problem the original PR was trying to fix.

Right, it is happening only in the Jetpack plugin.

Maybe we should fix it rather than revert it.
Definitely, I tried my hand at it but it seems a like a bit of work. So, I decided to do that in the next sprint.

I am merging this fix for now, so the social plugin's reviews work correctly.