Skip to content

Sharing Block: automatically add block to templates in block themes #35542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeherve merged 8 commits into from
Feb 22, 2024
Merged

Sharing Block: automatically add block to templates in block themes #35542

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d0e02cb
Sharing Block: automatically add block to templates in block themes
jeherve Feb 7, 2024
c0445f0
Wrap inner blocks in our sharing buttons markup.
jeherve Feb 8, 2024
9eb3fac
Fix anchor block reference
jeherve Feb 8, 2024
4c9112b
Wrap the whole thing in a group block
jeherve Feb 8, 2024
2286087
Avoid PHP warning
jeherve Feb 8, 2024
dc78a82
Merge remote-tracking branch 'origin/trunk' into add/hook-sharing-block
jeherve Feb 9, 2024
173ddde
Merge remote-tracking branch 'origin/trunk' into add/hook-sharing-block
jeherve Feb 21, 2024
877639d
Update hook to match updated filter signature in Core
jeherve Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Wrap the whole thing in a group block
  • Loading branch information
@jeherve
jeherve committed Feb 8, 2024
commit 4c9112b300d4308d1dbce62d8d603375d203d16f
21 changes: 14 additions & 7 deletions projects/plugins/jetpack/extensions/blocks/sharing-button/sharing-button.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,12 +259,6 @@ function add_default_services_to_block( $parsed_hooked_block, $relative_position
// Use the icon style by default.
$parsed_hooked_block['attrs']['styleType'] = 'icon';

// Does the anchor block have a layout attribute?
if ( isset( $parsed_anchor_block['attrs']['layout'] ) ) {
// Copy the anchor block's layout attribute to the hooked block.
$parsed_hooked_block['attrs']['layout'] = $parsed_anchor_block['attrs']['layout'];
}

// Add default services (inner blocks) to the block.
$parsed_hooked_block['innerBlocks'] = array(
array(
Expand Down Expand Up @@ -299,6 +293,19 @@ function add_default_services_to_block( $parsed_hooked_block, $relative_position
'</ul>',
);

return $parsed_hooked_block;
// Wrap the whole thing in a group block.
return array(
'blockName' => 'core/group',
'attrs' => array(
// Does the anchor block have a layout attribute? If so, use it in the group to maintain the same alignment.
'layout' => $parsed_anchor_block['attrs']['layout'] ?? 'null',
),
'innerBlocks' => array( $parsed_hooked_block ),
'innerContent' => array(
'<div class="wp-block-group">',
null,
'</div>',
),
);
}
add_filter( 'hooked_block_' . PARENT_BLOCK_NAME, __NAMESPACE__ . '\add_default_services_to_block', 10, 4 );