Google Fonts: Update the implementation of the print_font_faces (2nd try)

[arthur791004]

Related to #35890, #35983, WordPress/gutenberg#59376

Proposed changes:

• The returned value of the WP_Font_Face_Resolver::get_fonts_from_theme_json() is changing to an indexed array (here), so we cannot rely on the key of the returned value. As a result, this PR avoids using the key from the value and just loops the array to collect the fonts to print.
• Moreover, we added the key of the font slug alias to the returned value of that function as well (See c472144). Now we change to get the font slug aliases array first and then map the $fonts_in_use to its actual font family to get rid of using the key from the returned value of the WP_Font_Face_Resolver::get_fonts_from_theme_json()

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Apply this change to your WoA site via Jetpack Beta Tester
• Active TT4, Muscat
• Go to your homepage
• Make sure the font looks correct

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/google-fonts-print-font-faces branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/google-fonts-print-font-faces
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for April 2, 2024 (scheduled code freeze on March 25, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[fushar]

I am a bit lost. Is there any existing issue in production (or in theory) that this PR is fixing?

[arthur791004]

I am a bit lost. Is there any existing issue in production (or in theory) that this PR is fixing?

The returned value of the WP_Font_Face_Resolver::get_fonts_from_theme_json() is changing to an indexed array (WordPress/wordpress-develop#6161).

- if ( ! array_key_exists( $font_family_name, $fonts ) ) {
-   $fonts[ $font_family_name ] = array();
- }

- $fonts[ $font_family_name ] = static::convert_font_face_properties( $definition['fontFace'], $font_family_name );

+ $fonts[] = static::convert_font_face_properties( $definition['fontFace'], $font_family_name );

For example,

// before
$fonts = array(
	'Inter' =>
		array(
			array(
				'src'          =>
					array(
						'https://example.org/assets/fonts/inter/Inter-VariableFont_slnt,wght.ttf',
					),
				'font-family'  => 'Inter',
				'font-stretch' => 'normal',
				'font-style'   => 'normal',
				'font-weight'  => '200',
			),
		),
);

// after
$fonts = array(
	array(
		array(
			'src'          =>
				array(
					'https://example.org/assets/fonts/inter/Inter-VariableFont_slnt,wght.ttf',
				),
			'font-family'  => 'Inter',
			'font-stretch' => 'normal',
			'font-style'   => 'normal',
			'font-weight'  => '200',
		),
	),
);

As a result, we cannot use the key (font family) of $fonts to determine whether the font is in use or not. Instead, we have to take the font family from the first element of the font faces array and use it to check whether we should print this font.

[fushar]

Thanks for the explanation. After adding debug statements here and there in my WoA site, I think I understand now.

This works well on Muscat and TT4 👍