Skip to content

Social: Update share status modal to use Dataviews component #39230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manzoorwanijk merged 11 commits into from
Sep 6, 2024
Merged

Social: Update share status modal to use Dataviews component #39230

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6d85fac
Add @wordpress/dataviews as a dependency
manzoorwanijk Sep 4, 2024
1ea7f08
Create and use the dataview component
manzoorwanijk Sep 4, 2024
e63e6cf
Do some makeup
manzoorwanijk Sep 4, 2024
9ac2fe0
Render and clean up
manzoorwanijk Sep 4, 2024
eb73df1
Add changelog
manzoorwanijk Sep 4, 2024
066684f
Copy paste clean up from previous PR
manzoorwanijk Sep 4, 2024
03762fb
Pass data from parent to avoid duplication
manzoorwanijk Sep 4, 2024
1aba079
Merge branch 'trunk' into update/social-share-status-modal-to-use-dat…
manzoorwanijk Sep 5, 2024
830355b
Use only the styles from dataviews for now
manzoorwanijk Sep 6, 2024
21fcc9a
Restore link styles
manzoorwanijk Sep 6, 2024
331b18c
Add a comment about the color
manzoorwanijk Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do some makeup
  • Loading branch information
@manzoorwanijk
manzoorwanijk committed Sep 4, 2024
commit e63e6cf68474bed79b8aef556de02e97e70f386e
42 changes: 30 additions & 12 deletions projects/js-packages/publicize-components/src/components/share-status/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import '@wordpress/dataviews/build-style/style.css';

.trigger-wrapper {
margin-top: 1rem;
padding-block: 1rem;
Expand All @@ -8,7 +10,7 @@
padding-block: 1rem;
}

.spinner{
.spinner {
margin: 0 1rem 1rem 1rem;
}

Expand All @@ -31,12 +33,6 @@
border-bottom: 1px solid var(--jp-gray-5);
}
}

.share-item {
display: flex;
gap: 1rem;
align-items: center;
}
}

.share-item-name-wrapper {
Expand All @@ -55,7 +51,6 @@
.share-status-wrapper {
display: flex;
align-items: center;
width: 5rem;

&.share-status-success {
color: var(--jp-green-50);
Expand Down Expand Up @@ -85,10 +80,33 @@
fill: var(--jp-green-50);
}

.share-status-action-wrapper {
width: 3rem;
.disconnected-icon {
display: block;
}

.disconnected-icon{
display: block;
.dataview-wrapper {

// Hide the table actions
:global(.dataviews__view-actions) {
display: none;
}

// Make the table header buttons unclickable
:global(.dataviews-view-table-header-button) {
pointer-events: none;
}

// Make the actions column right-aligned
:global(.dataviews-view-table__row th:last-child),
:global(.dataviews-view-table__row td:last-child) {
text-align: end;
}
:global(.dataviews-view-table__row td:last-child) {
width: 1%;
}

.connection-name {
display: flex;
align-items: center;
}
}