Skip to content

Conversation

@fgiannar
Copy link
Contributor

@fgiannar fgiannar commented Sep 12, 2024

This PR removes actions and filters related to the Masterbar module.
The later is being deprecated (see product discussion) and WoA sites already load all Masterbar functionality via the masterbar package and independently of the module.
Therefore having the module active/inactive is redundant for WoA sites.
No functionality should be affected as this PR is removing all actions and filters that are related to the masterbar module.
This will allow us to completely remove the module from the Jetpack plugin in an upcoming release.

Proposed changes:

  • On init: Stop force-enabling the masterbar module
  • jetpack_get_available_modules filter: Stop conditionally unsetting the masterbar module upon fetching the Jetpack available modules
  • jetpack_modules_list_table_items filter: Stop unsetting the masterbar module upon fetching the old Jetpack module list

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pfwV0U-3U-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@fgiannar fgiannar added [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Status] Needs Team Review Obsolete. Use Needs Review instead. and removed [Status] In Progress labels Sep 12, 2024
@fgiannar fgiannar requested a review from a team September 12, 2024 05:37
@coder-karen coder-karen self-requested a review September 12, 2024 08:13
Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, no fatals / warnings 👍

@fgiannar fgiannar merged commit 5d37c1f into trunk Sep 12, 2024
@fgiannar fgiannar deleted the update/wpcomsh-remove-masterbar-module-references branch September 12, 2024 11:18
@github-actions github-actions bot removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Sep 12, 2024
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
…39367)

* Wpcomsh: Remove actions and filters related to the Masterbar module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Plugin] Wpcomsh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants