Skip to content

Social | Fix dataviews styles imported in share status being added globally #39991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manzoorwanijk merged 1 commit into from
Nov 1, 2024
Merged

Social | Fix dataviews styles imported in share status being added globally #39991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...-packages/publicize-components/changelog/fix-social-dataviews-styles-being-added-globally
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Fixed dataviews styles imported in share status being added globally
12 changes: 10 additions & 2 deletions projects/js-packages/publicize-components/src/components/share-status/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
@import '@wordpress/dataviews/build-style/style.css';

.trigger-wrapper {
margin-top: 1rem;
padding-block: 1rem;
Expand Down Expand Up @@ -65,6 +63,16 @@
}

.dataview-wrapper {
/**
* We have to use scoped import to avoid styles being added globally.
* By importing the styles here, all the styles from dataviews package will be scoped to this component.
* @see https://github.com/Automattic/jetpack/issues/39981
*/
// Use :global scope to avoid CSS encapsulation
:global {
// Use import without ".css" extension to avoid it being rendered as URL
@import '@wordpress/dataviews/build-style/style';
}

// Hide the table actions
:global(.dataviews__view-actions) {
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/fix-social-dataviews-styles-being-added-globally
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: bugfix

Fixed dataviews styles imported in share status being added globally
4 changes: 4 additions & 0 deletions projects/plugins/social/changelog/fix-social-dataviews-styles-being-added-globally
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Fixed dataviews styles imported in share status being added globally
Loading