Scan Package: Migrate Components #41654

nateweller · 2025-02-07T22:35:47Z

Proposed changes:

Moves threat components out of @automattic/jetpack-components and into @automattic/jetpack-scan.
- Updates translation text domains.
- Updates imports.
Removes the component's package dependency on @wordpress/dataviews
Removes the component's package dependency on @automattic/jetpack-scan
Adds supporting dependencies to the scan package.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

peb6dq-3ta-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Smoke test Jetpack Protect, ensuring the threat severity badge renders in scan results.
Ensure upgrade compatibility (i.e. update Jetpack to use this branch while Protect uses production, and vice versa).

github-actions · 2025-02-07T22:37:04Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2025-02-09T02:20:44Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the migrate/components/scan branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack migrate/components/scan

bin/jetpack-downloader test jetpack-mu-wpcom-plugin migrate/components/scan

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-02-09T02:45:17Z

Code Coverage Summary

Cannot generate coverage summary while tests are failing. 🤐

Please fix the tests, or re-run the Code coverage job if it was something being flaky.

Full summary · PHP report · JS report

jp-launch-control · 2025-02-23T02:03:48Z

Code Coverage Summary

Coverage changed in 3 files.

File	Coverage	Δ%	Δ Uncovered
projects/js-packages/components/components/badge/index.tsx	1/3 (33.33%)	-66.67%	2 ❤️‍🩹
projects/js-packages/scan/src/constants/index.ts	2/2 (100.00%)	100.00%	-2 💚
projects/js-packages/scan/src/utils/index.ts	23/68 (33.82%)	33.82%	-23 💚

14 files are newly checked for coverage. Only the first 5 are listed here.

File	Coverage
projects/js-packages/scan/src/components/threat-modal/threat-actions.tsx	1/18 (5.56%) 💔
projects/js-packages/scan/src/components/threat-modal/threat-fix-details.tsx	1/15 (6.67%) 💔
projects/js-packages/scan/src/components/threat-modal/fixer-state-notice.tsx	1/10 (10.00%) 💔
projects/js-packages/scan/src/components/threat-modal/threat-technical-details.tsx	1/8 (12.50%) 💔
projects/js-packages/scan/src/components/threat-modal/index.tsx	1/4 (25.00%) ❤️‍🩹

Full summary · PHP report · JS report

_{If appropriate, add one of these labels to override the failing coverage check:

Covered by non-unit tests
Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.}

projects/plugins/protect/changelog/migrate-components-scan

projects/js-packages/scan/changelog/migrate-components-scan

nateweller · 2025-03-17T16:58:14Z

projects/js-packages/components/index.ts

 export type { ButtonProps } from './components/button/types.js';
 export { default as LoadingPlaceholder } from './components/loading-placeholder/index.js';
 export { default as TermsOfService } from './components/terms-of-service/index.js';
+export { default as Badge } from './components/badge/index.js';


Exporting Badge here so threat components can use it from their new home in the scan package.

anomiex

Looks reasonable to me from a Garage perspective. Haven't tested though.

anomiex · 2025-03-17T17:11:05Z

projects/js-packages/components/changelog/remove-threat-components

@@ -0,0 +1,4 @@
+Significance: major


It is! Thanks!

projects/js-packages/components/changelog/remove-threat-components

changelog changelog Update changelog Update changelog changelog

dkmyta

Changes look good, and the component renders well in Protect and handle varying versions when compatibility testing.

One thing I will note though, and this may be intentional but there is now a slight variation in styling for the SeverityBadge from trunk when compared against the feature branch:

Trunk:

Feature branch:

nateweller · 2025-03-25T19:26:17Z

One thing I will note though, and this may be intentional but there is now a slight variation in styling for the SeverityBadge from trunk when compared against the feature branch

This is the updated badge design from the Protect Meets Core project, should be fine to merge into trunk early IMO 👍

nateweller changed the base branch from trunk to add/components/js-imports February 7, 2025 22:36

github-actions bot added [JS Package] Components [JS Package] Scan [JS Package] Script Data [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress [Tests] Includes Tests RNA labels Feb 7, 2025

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Feb 7, 2025

nateweller mentioned this pull request Feb 7, 2025

Protect Components: Use @wordpress/dataviews/wp import path #41510

Merged

3 tasks

nateweller force-pushed the add/components/js-imports branch from 5142a6c to 643217f Compare February 9, 2025 02:18

nateweller force-pushed the migrate/components/scan branch from af7e208 to dff3b78 Compare February 9, 2025 02:19

nateweller added the [Type] Janitorial label Feb 9, 2025

nateweller force-pushed the add/components/js-imports branch from 643217f to 93a48e4 Compare February 10, 2025 00:08

nateweller self-assigned this Feb 10, 2025

nateweller force-pushed the migrate/components/scan branch from 08668ad to e62f892 Compare February 10, 2025 01:50

nateweller force-pushed the add/components/js-imports branch from 878df52 to 60f0892 Compare February 12, 2025 18:18

Base automatically changed from add/components/js-imports to trunk February 15, 2025 21:31

github-actions bot added [JS Package] Storybook [JS Package] Webpack Config labels Feb 15, 2025

nateweller force-pushed the migrate/components/scan branch 2 times, most recently from 95f24d4 to 67e1bde Compare February 23, 2025 01:48

nateweller force-pushed the migrate/components/scan branch from 67e1bde to 0f9932e Compare February 23, 2025 17:49

nateweller changed the base branch from trunk to add/components/build February 23, 2025 17:50

nateweller commented Feb 23, 2025

View reviewed changes

projects/plugins/protect/changelog/migrate-components-scan Outdated Show resolved Hide resolved

nateweller commented Feb 23, 2025

View reviewed changes

projects/js-packages/scan/changelog/migrate-components-scan Outdated Show resolved Hide resolved

nateweller commented Mar 17, 2025

View reviewed changes

nateweller requested review from a team March 17, 2025 16:59

nateweller marked this pull request as ready for review March 17, 2025 16:59

github-actions bot added the [Tests] Includes Tests label Mar 17, 2025

anomiex reviewed Mar 17, 2025

View reviewed changes

nateweller force-pushed the migrate/components/scan branch 3 times, most recently from 7d122ad to a44f790 Compare March 22, 2025 18:19

nateweller added 4 commits March 24, 2025 15:01

Move threat components from jetpack-components to jetpack-scan

a80157f

changelog changelog Update changelog Update changelog changelog

Fix package versions

89e792e

fix deps sort order

57e8ab4

Fix tests

3a76ec3

nateweller force-pushed the migrate/components/scan branch from a44f790 to 3a76ec3 Compare March 24, 2025 21:01

dkmyta reviewed Mar 24, 2025

View reviewed changes

nateweller requested a review from dkmyta March 25, 2025 19:26

dkmyta approved these changes Mar 25, 2025

View reviewed changes

nateweller merged commit 7a0c82f into trunk Mar 25, 2025
81 of 83 checks passed

nateweller deleted the migrate/components/scan branch March 25, 2025 21:25

github-actions bot added this to the protect/4.1.0 milestone Mar 25, 2025

github-actions bot removed the [Status] Needs Review This PR is ready for review. label Mar 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Scan Package: Migrate Components #41654

Scan Package: Migrate Components #41654

Uh oh!

nateweller commented Feb 7, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 7, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 9, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Feb 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

nateweller Mar 17, 2025

Uh oh!

anomiex left a comment

Uh oh!

anomiex Mar 17, 2025

Uh oh!

Uh oh!

dkmyta left a comment •

edited

Loading

Uh oh!

nateweller commented Mar 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Scan Package: Migrate Components #41654

Scan Package: Migrate Components #41654

Uh oh!

Conversation

nateweller commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

jp-launch-control bot commented Feb 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Uh oh!

Uh oh!

nateweller Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

anomiex left a comment

Choose a reason for hiding this comment

Uh oh!

anomiex Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dkmyta left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nateweller commented Mar 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nateweller commented Feb 7, 2025 •

edited

Loading

github-actions bot commented Feb 7, 2025 •

edited

Loading

github-actions bot commented Feb 9, 2025 •

edited

Loading

github-actions bot commented Feb 9, 2025 •

edited

Loading

jp-launch-control bot commented Feb 23, 2025 •

edited

Loading

dkmyta left a comment •

edited

Loading