Repo Gardening: do not add label to assigned issues#42246
Merged
Conversation
Fixes Automattic/studio#1012 Until now, when a PR was opened to close a specific issue, the assignIssues task did 2 things: 1. Assign the issue to the person working on the PR, to indicate to everyone following the issue that it is being worked on, and to hold the person opening the PR accountable. 2. Add the "[Status] In Progress" label to indicate that the issue is being worked on. With the GitHub UI improvements in the past few years, PRs opened to close a specific issue are a lot more visible than they once were. The "In Progress" label is consequently not that useful anymore. Let's remove it.
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
This was referenced Mar 6, 2025
anomiex
approved these changes
Mar 6, 2025
Contributor
anomiex
left a comment
There was a problem hiding this comment.
🤷 I see you can search with linked:pr to find issues that have an associated PR. I don't know whether anyone is using [Status] In Progress manually as well as automatically such that they might find this useful. But if they do, we could always revert this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Automattic/studio#1012
Proposed changes:
Until now, when a PR was opened to close a specific issue, the assignIssues task did 2 things:
With the GitHub UI improvements in the past few years, PRs opened to close a specific issue are a lot more visible than they once were. The "In Progress" label is consequently not that useful anymore. Let's remove it.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
trunkbranch locally, and push that version oftrunkto a fork of this repo.