Skip to content

Repo Gardening: do not add label to assigned issues#42246

Merged
jeherve merged 1 commit intotrunkfrom
rm/repo-gardening-assignment-progress-label
Mar 6, 2025
Merged

Repo Gardening: do not add label to assigned issues#42246
jeherve merged 1 commit intotrunkfrom
rm/repo-gardening-assignment-progress-label

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Mar 6, 2025

Fixes Automattic/studio#1012

Proposed changes:

Until now, when a PR was opened to close a specific issue, the assignIssues task did 2 things:

  1. Assign the issue to the person working on the PR, to indicate to everyone following the issue that it is being worked on, and to hold the person opening the PR accountable.
  2. Add the "[Status] In Progress" label to indicate that the issue is being worked on.

With the GitHub UI improvements in the past few years, PRs opened to close a specific issue are a lot more visible than they once were. The "In Progress" label is consequently not that useful anymore. Let's remove it.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Merge this PR into your trunk branch locally, and push that version of trunk to a fork of this repo.
  • Create an issue in your fork.
  • Open a PR that makes a change, and includes "Fixes #xxx" in the PR description.
  • Observe that you get automatically assigned to the issue, but no progress label is added.

Fixes Automattic/studio#1012

Until now, when a PR was opened to close a specific issue, the assignIssues task did 2 things:

1. Assign the issue to the person working on the PR, to indicate to everyone following the issue that it is being worked on, and to hold the person opening the PR accountable.
2. Add the "[Status] In Progress" label to indicate that the issue is being worked on.

With the GitHub UI improvements in the past few years, PRs opened to close a specific issue are a lot more visible than they once were. The "In Progress" label is consequently not that useful anymore. Let's remove it.
@jeherve jeherve added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. Actions GitHub actions used to automate some of the work around releases and repository management [Action] Repo Gardening Github Action: manage PR and issues in your Open Source project labels Mar 6, 2025
@jeherve jeherve requested review from a team, inaikem and richtabor March 6, 2025 08:37
@jeherve jeherve self-assigned this Mar 6, 2025
@github-actions github-actions bot added the Docs label Mar 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 I see you can search with linked:pr to find issues that have an associated PR. I don't know whether anyone is using [Status] In Progress manually as well as automatically such that they might find this useful. But if they do, we could always revert this.

@jeherve jeherve merged commit 71f4e94 into trunk Mar 6, 2025
63 checks passed
@jeherve jeherve deleted the rm/repo-gardening-assignment-progress-label branch March 6, 2025 18:34
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management Docs Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable "[Status] In Progress" Github action labeling

2 participants