Jetpack Forms: cleanup dashboard migration code

[CGastrell]

WIP

Part of FORMS-133

Proposed changes:

This PR removes all code related to the dashboard and menu item migration

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

No

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Sadly these removals don't have a very consistent way of being tested. Run tests with jetpack test php packages/forms.
Then navigate wp-admin. See that Jetpack > Forms works fine. See that installing polldaddy plugin will trigger the Feedback menu on the sidebar.
Sync to a JN site and a Simple site, verify nothing breaks on Calypso.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the remove/jetpack-forms-dashboard-migration-cleanup branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack remove/jetpack-forms-dashboard-migration-cleanup

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form-plugin.php	471/1379 (34.16%)	0.29%	-12 💚

Full summary · PHP report · JS report

_{Coverage check overridden by Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR .}

[github-actions]

This PR has been marked as stale. This happened because:

• It has been inactive for the past 3 months.
• It hasn't been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Status] Keep Open`, etc.

If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.

[edanzer]

Any specific reason to convert this to a static function? No big deal. Just curious. We should be sure we catch any other places the function is used (if relevant).

[CGastrell]

Yes, we don't want to be instancing the dashboard switch class when we don't need it, it's a simple mechanism. And previous changes remove the initial instantiation of the class, so there's no more a way to call it as a class method, only static. The same function exists on Dashboard class. The original idea was to delete the method (or the entire class), this is the safer approach.

[edanzer]

Changes look sane. I tested this in both self hosted and WordPress.com environments, since menu logic is a bit different in those places. Everything is working well for me in both environments. Also tests pass.

I added a few questions.

I think the main concern with this will be whether there are edge cases where users are still using the old / classic Feedback page. It's tricky to identify those cases (if they exist) and test them.

@CGastrell knows this menu space very well. So if he feels comfortable with my questions, and given everything is working, I think we'd be good to merge this. Still holding no approving though, since I'm not sure on edge cases myself yet.