CRM: Moves clearing of roles to uninstall hook and returns early if a CRM role is found during role creation

[mikestottuk]

Fixes #

Proposed changes:

• Returns early if a CRM user role is found
• Moves the removal of CRM roles to the uninstall hook

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• This change should only destroy CRM user roles when the plugin is deleted, not each time it is activated. In addition the creation of roles will return early if a role is found.

In a future enhancement, we should consider delaying the creation of additional CRM roles until the CRM operate decides they need them.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

Coverage changed in 3 files.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/crm/ZeroBSCRM.php	0/179 (0.00%)	0.00%	8 💔
projects/plugins/crm/includes/ZeroBSCRM.Permissions.php	0/456 (0.00%)	0.00%	2 ❤️‍🩹
projects/plugins/crm/includes/ZeroBSCRM.Core.php	0/972 (0.00%)	0.00%	-1 💚

Full summary · PHP report

_{Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .}

[tbradsha]

Two thoughts:

1. Obviously this code predates me, but I suspect the goal with clearing the roles prior to creation is that if the role perms change they wouldn't be properly set up.
2. Is it really safe to assume that if a role exists, it's set up properly? I'd be more comfortable setting them up from a clean slate.

[github-actions]

This PR has been marked as stale. This happened because:

• It has been inactive for the past 3 months.
• It hasn't been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Status] Keep Open`, etc.

If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.

[mikestottuk]

Two thoughts:

1. Obviously this code predates me, but I suspect the goal with clearing the roles prior to creation is that if the role perms change they wouldn't be properly set up.
2. Is it really safe to assume that if a role exists, it's set up properly? I'd be more comfortable setting them up from a clean slate.

Clearing them prior presumably was to allow for any changes to the roles or permissions to take effect on a plugin update - that said, IIRC we've not changed the roles setup in the history of the product and I don't think we'll be changing them any time soon either.

[tbradsha]

I didn't test, but in general it looks like a good improvement. Two questions:

1. Presumably remove_role() only removes the role definition, not the role attribute from individual users? I assume that has to be the case or we'd have issues when people uninstall/reinstall and try to use various CRM users.
2. Should the other zeroBSCRM_clearUserRoles() calls be reviewed?

[github-actions]

This PR has been marked as stale. This happened because:

• It has been inactive for the past 3 months.
• It hasn't been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Status] Keep Open`, etc.

If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.