Skip to content

Forms: Removes the classic admin initialization call #44538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
enejb wants to merge 12 commits into from
+324 −66
Closed

Forms: Removes the classic admin initialization call #44538

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6e32385
Forms: Depreacte Classic Admin
enejb Jul 30, 2025
bbd4a86
changelog
enejb Jul 30, 2025
966d4bd
move gdrive export to plugin class
CGastrell Sep 4, 2025
c67e019
We don't need to move this method.
enejb Sep 4, 2025
3793d3d
Deprecate the method.
enejb Sep 4, 2025
855ada5
Fixes for phan
enejb Sep 4, 2025
00288aa
Update phan baseline
enejb Sep 5, 2025
d3a98e6
Code clean up
enejb Sep 5, 2025
ef1020c
add tests and phan baseline to allow deprecated function call
CGastrell Sep 9, 2025
d0ea922
add tests for export_to_gdrive delegation
CGastrell Sep 9, 2025
41cc372
Apply suggestion from @Copilot
enejb Sep 10, 2025
7d5b379
reinstate csv column array building even on empty values
CGastrell Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code clean up
  • Loading branch information
@enejb @CGastrell
enejb authored and CGastrell committed Sep 23, 2025
commit d3a98e640165a86b32f3d1ae5c139e5c9589b00a
3 changes: 0 additions & 3 deletions projects/packages/forms/src/contact-form/class-contact-form-plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3472,7 +3472,6 @@ public function export_to_gdrive() {
__( 'You aren\'t authorized to do that.', 'jetpack-forms' ),
403
);

return;
}

Expand All @@ -3494,8 +3493,6 @@ public function export_to_gdrive() {
foreach ( $fields as $single_field_name ) {
if ( isset( $export_data[ $single_field_name ][ $i ] ) ) {
$current_row[] = $export_data[ $single_field_name ][ $i ];
} else {
$current_row[] = '';
}
}

Expand Down