Skip to content

Forms: Use Core buttons instead of Jetpack buttons #45007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lezama wants to merge 16 commits into
base: trunk
Choose a base branch
from
+496 −63
Open

Forms: Use Core buttons instead of Jetpack buttons #45007

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
57725d7
Switch contact form submit button to core/buttons block
lezama Aug 28, 2025
8066c25
simpler
lezama Aug 28, 2025
05e4398
Restrict flex styling to specific wp-block elements
lezama Aug 28, 2025
bed35f0
Add spinner animation for submitting form button
lezama Aug 28, 2025
dfdbd59
Restrict tag processing to button and update submit styles
lezama Aug 28, 2025
57e1c87
changelog
lezama Aug 28, 2025
80d8670
Update projects/packages/forms/src/blocks/contact-form/variations.js
lezama Aug 29, 2025
00d63f9
Refactor render_submit_button to improve clarity
lezama Aug 29, 2025
3f1849f
Update projects/packages/forms/src/blocks/contact-form/variations.js
lezama Sep 15, 2025
7aee2f9
add some tests to improve coverage
CGastrell Sep 16, 2025
46c0779
fix disabled and submitting states
CGastrell Sep 16, 2025
12c24bb
update tests after attribute addition
CGastrell Sep 16, 2025
c7684da
modify useformwrapper to use core/buttons as well
CGastrell Sep 16, 2025
2bfc41f
Apply suggestion from @manzoorwanijk
lezama Sep 17, 2025
7102244
Update projects/packages/forms/src/blocks/contact-form/class-contact-…
lezama Sep 17, 2025
fac10d5
change patterns to use core buttons
CGastrell Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restrict tag processing to button and update submit styles
  • Loading branch information
@lezama @CGastrell
lezama authored and CGastrell committed Nov 28, 2025
commit dfdbd59d22364f6c9ddd6fe4dd2f79c9f8228bcc
2 changes: 1 addition & 1 deletion projects/packages/forms/src/blocks/contact-form/class-contact-form-block.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public static function render_submit_button( $content, $parsed_block ) {
}

$p = new \WP_HTML_Tag_Processor( $content );
if ( ! $p->next_tag( array( 'tag_name' => array( 'button', 'a' ) ) ) ) {
if ( ! $p->next_tag( array( 'tag_name' => 'button' ) ) ) {
return $content;
}

Expand Down
1 change: 0 additions & 1 deletion projects/packages/forms/src/contact-form/css/grunion.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1308,7 +1308,6 @@ on production builds, the attributes are being reordered, causing side-effects
display: none;
}

.jetpack-form-submit-button.is-submitting .wp-block-button__link::after,
.jetpack-form-submit-button.is-submitting button::after {
content: "";
display: inline-block;
Expand Down