Forms: Add form fill duration to feedback #45786

enejb · 2025-11-06T06:06:34Z

This PR add a form fill duration to each of the form responses.
We start the timer when the user interacts with the for for the first time.

This is done so that we can track ow long the form take to fill out.

Proposed changes:

Add a new feedback field that we store and return the date in seconds.
Start recording the data as soon as the user focuses in to the form. And record the time when they submit the form.
Store the data on the feedback class.
Add the data to the end point so that we can display it to the user when they view it.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

See p1762390969490259-slack-C086RGTJT1D

Does this pull request change what data or activity we track or use?

Yes, we track how long it takes the user to submit the form.

Testing instructions:

Create a form.
Fill it out. Test this across browser and different devices. Also test out form fields such as file upload.
Notice that we have the data recorded as expected.

github-actions · 2025-11-06T06:07:31Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/forms-submit-timer branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/forms-submit-timer

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-11-06T06:07:41Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: December 2, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copilot

Pull Request Overview

This PR adds form fill duration tracking to Jetpack forms, measuring the time from a user's first interaction with a form to submission. This feature provides valuable analytics data for form optimization.

Tracks form fill duration in seconds from first user interaction to submission
Persists duration data in feedback entries and exposes it via REST API
Adds frontend JavaScript tracking and backend PHP support

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
projects/plugins/jetpack/changelog/add-forms-submit-timer	Changelog entry for Jetpack plugin
projects/packages/forms/changelog/add-forms-submit-timer	Changelog entry for forms package
projects/packages/forms/src/contact-form/class-feedback.php	Adds form_fill_duration property and getter method
projects/packages/forms/src/contact-form/class-contact-form.php	Adds hidden input field and focusin event handler
projects/packages/forms/src/contact-form/class-contact-form-endpoint.php	Adds form_fill_duration to REST API schema and response
projects/packages/forms/src/modules/form/view.js	Implements JavaScript tracking logic for form interaction timing
projects/packages/forms/tests/php/contact-form/class-utility.php	Updates test utility to support form_fill_duration in test requests
projects/packages/forms/tests/php/contact-form/Feedback_Test.php	Adds test for form_fill_duration persistence

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-06T06:09:46Z

projects/packages/forms/src/modules/form/view.js

+				// Calculate and set the form fill duration before submission
+				if ( context.formFirstInteractionTime ) {
+					const duration = Math.round( ( Date.now() - context.formFirstInteractionTime ) / 1000 ); // Duration in seconds
+					const form = document.getElementById( 'jp-form-' + context.formHash );
+					if ( form ) {
+						const durationField = form.querySelector( 'input[name="form_fill_duration"]' );
+						if ( durationField ) {
+							durationField.value = duration;
+						}
+					}
+				}


The form fill duration is only calculated when context.useAjax is true (line 464). For non-AJAX form submissions, the duration field will remain at its default value of '0'. The duration calculation logic should be moved before the if ( context.useAjax ) check (after line 462) to ensure it works for both AJAX and non-AJAX submissions.

Copilot · 2025-11-06T06:09:46Z

projects/packages/forms/src/contact-form/class-contact-form-endpoint.php

+			'type'        => array( 'integer', 'null' ),
+			'context'     => array( 'view', 'edit', 'embed' ),
+			'arg_options' => array(
+				'sanitize_callback' => 'absint',


The sanitize_callback 'absint' will convert null values to 0, which is inconsistent with the schema type that allows null. This will prevent null values from being properly represented in the API response for older submissions. Consider using a custom sanitization callback that preserves null values or removing the sanitize_callback since the field is readonly and already sanitized during storage.

Suggested change

'sanitize_callback' => 'absint',

jp-launch-control · 2025-11-06T06:16:11Z

Code Coverage Summary

Coverage changed in 4 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/modules/form/view.js	0/283 (0.00%)	0.00%	10 💔
projects/packages/forms/src/contact-form/class-contact-form-endpoint.php	767/895 (85.70%)	0.18%	0 💚
projects/packages/forms/src/contact-form/class-contact-form.php	835/1208 (69.12%)	0.03%	0 💚
projects/packages/forms/src/contact-form/class-feedback.php	653/687 (95.05%)	0.03%	0 💚

Full summary · PHP report · JS report

_{If appropriate, add one of these labels to override the failing coverage check:

Covered by non-unit tests
Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.}

enejb added 2 commits November 5, 2025 21:55

Forms: Add form fill duration

de75125

changelog

0d5249f

enejb requested review from a team and Copilot November 6, 2025 06:06

enejb added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Status] Needs Testing We need to add this change to the testing call for this month's release [Package] Forms labels Nov 6, 2025

github-actions bot added [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests labels Nov 6, 2025

Copilot AI reviewed Nov 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Forms: Add form fill duration to feedback #45786

Forms: Add form fill duration to feedback #45786

Uh oh!

enejb commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

jp-launch-control bot commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Forms: Add form fill duration to feedback #45786

Are you sure you want to change the base?

Forms: Add form fill duration to feedback #45786

Uh oh!

Conversation

enejb commented Nov 6, 2025

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

jp-launch-control bot commented Nov 6, 2025

Code Coverage Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Nov 6, 2025 •

edited

Loading

github-actions bot commented Nov 6, 2025 •

edited

Loading