Skip to content

Conversation

@edanzer
Copy link
Contributor

@edanzer edanzer commented Nov 25, 2025

Proposed changes:

This is a spike/test to offer centralized form management based on synced patterns. Broadly, here's what's done:

  • Dashboard > Forms Screen
    • Add new 'Forms' screen that pulls a list of forms from synced patterns.
    • This does not include forms added via blocks in pages and posts yet.
    • List is loaded in a dataviews table with minimal info
    • Added link to Edit form in site editor,
    • Added link to View responses -> goes to responses screen with responses filtered by form
    • Added link to View stats -> opens side panel like individual response with demo stats data
  • Dashboard > Responses Screen
    • Added filtering based on Form
  • Dashboard > Navigation
    • Added View Responses / View Forms button to toggle between screens
    • Updated Create Form button to create a new synced pattern with form block added
  • Site Editor
    • Add Jetpack Forms pattern category - new forms are automatically created there
    • When adding/editing form pattern, there's a button to View Forms to go back to Jetpack > Forms list
  • Block Editor
    • Central form patterns show in the block inserter
    • To edit a form, you cannot do it directly from the page/post - you must go to site editor
    • Added Shared Forms panel that allows you to save a form block as a synced pattern
  • Backend/Other
    • Added endpoint to fetch forms
    • Added block attribute ID to each form block (regardless of where inserted, all synced pattern have the same form id)
    • Some other needed backend logic

SCREENSHOT
forms-list

VIDEO DEMO

form-synced-patterns.mp4

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

You can load this up and trying playing around with forms dashboard and forms block to tests synced pattern behaviors.

@edanzer edanzer requested a review from a team November 25, 2025 01:39
@edanzer edanzer self-assigned this Nov 25, 2025
@edanzer edanzer added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Pri] Normal [Block] Contact Form Form block (also see Contact Form label) [Package] Forms labels Nov 25, 2025
@github-actions
Copy link
Contributor

Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete.

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link

jp-launch-control bot commented Nov 25, 2025

Code Coverage Summary

Cannot generate coverage summary while tests are failing. 🤐

Please fix the tests, or re-run the Code coverage job if it was something being flaky.

Full summary · PHP report · JS report

@edanzer edanzer force-pushed the try/forms-synced-patterns branch from 27fffe8 to 4cf9ef2 Compare December 4, 2025 06:41
@edanzer edanzer force-pushed the try/forms-synced-patterns branch from 4cf9ef2 to b6fec21 Compare December 4, 2025 16:12
@simison simison added DO NOT MERGE don't merge it! and removed [Status] Needs Review This PR is ready for review. labels Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Contact Form Form block (also see Contact Form label) DO NOT MERGE don't merge it! [Feature] Contact Form [Package] Forms [Pri] Normal [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants