Skip to content

Forms: replace jetpack buttons with core #46166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CGastrell wants to merge 24 commits into
base: trunk
Choose a base branch
from
Open

Forms: replace jetpack buttons with core #46166

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
960b14e
Switch contact form submit button to core/buttons block
lezama Aug 28, 2025
94dc303
simpler
lezama Aug 28, 2025
4afd338
Restrict flex styling to specific wp-block elements
lezama Aug 28, 2025
0a031dc
Add spinner animation for submitting form button
lezama Aug 28, 2025
eb68e33
Restrict tag processing to button and update submit styles
lezama Aug 28, 2025
f580718
changelog
lezama Aug 28, 2025
a2b5ee8
Update projects/packages/forms/src/blocks/contact-form/variations.js
lezama Aug 29, 2025
1631c74
Refactor render_submit_button to improve clarity
lezama Aug 29, 2025
5680597
Update projects/packages/forms/src/blocks/contact-form/variations.js
lezama Sep 15, 2025
fa801bf
add some tests to improve coverage
CGastrell Sep 16, 2025
91cb276
fix disabled and submitting states
CGastrell Sep 16, 2025
47e374e
update tests after attribute addition
CGastrell Sep 16, 2025
0137dd6
modify useformwrapper to use core/buttons as well
CGastrell Sep 16, 2025
dc8eb8c
Apply suggestion from @manzoorwanijk
lezama Sep 17, 2025
195479e
Update projects/packages/forms/src/blocks/contact-form/class-contact-…
lezama Sep 17, 2025
ed1baf4
change patterns to use core buttons
CGastrell Sep 17, 2025
1dd086e
switch core/buttons for core/button
CGastrell Dec 2, 2025
16f2f87
changelog
CGastrell Dec 2, 2025
980549d
make core buttons take the same styles as previous jetpack buttons
CGastrell Dec 2, 2025
f498f11
avoid margins on buttons
CGastrell Dec 3, 2025
7cc9793
add conditional so php8.5 test doesn't fail due to deprecated method
CGastrell Dec 5, 2025
0c65608
fix/remove comments
CGastrell Dec 11, 2025
b1e13a3
search/replace the right blocks, it's now button, not buttons
CGastrell Dec 11, 2025
9f31eb8
more specific naming for the button spinner
CGastrell Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
avoid margins on buttons
  • Loading branch information
@CGastrell
CGastrell committed Dec 11, 2025
commit f498f115ceba34cc5d0763a280191aa792eca422
1 change: 1 addition & 0 deletions projects/packages/forms/src/blocks/contact-form/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
min-height: var(--jetpack--contact-form--input-height, auto);
align-self: flex-end;
line-height: 1;
margin-block: 0;

.wp-block-button__link {
min-height: var(--jetpack--contact-form--input-height, auto);
Expand Down