Skip to content

Improve Post Stats cache handling for invalid or error data #46211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dognose24 merged 10 commits into from
Dec 9, 2025
Merged

Improve Post Stats cache handling for invalid or error data #46211

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e0ceb39
Remove post stats cache
dognose24 Dec 5, 2025
8877038
changelog
dognose24 Dec 5, 2025
a736465
Improve post stats cache handling for invalid or error data
dognose24 Dec 5, 2025
ffe8c0c
Update changelog
dognose24 Dec 5, 2025
3c3624b
Merge branch 'trunk' into update/blog_stats_debug
dognose24 Dec 9, 2025
4ba2b0e
Respect the cache first and return errors or invalid data as they were
dognose24 Dec 9, 2025
68d3fe3
Keep WP errors from cache along with the valid response
dognose24 Dec 9, 2025
3bbe021
Update annotations
dognose24 Dec 9, 2025
5b9fc39
Update annotations
dognose24 Dec 9, 2025
bd5a7b1
Apply suggestions from code review
kangzj Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove post stats cache
  • Loading branch information
@dognose24
dognose24 committed Dec 5, 2025
commit e0ceb39bf6647b2a8c446388a8b7a4ccbc7d4a78
35 changes: 2 additions & 33 deletions projects/packages/stats/src/class-wpcom-stats.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,39 +496,8 @@ protected function fetch_stats( $args = array() ) {
* @return array|WP_Error
*/
protected function fetch_post_stats( $args, $post_id ) {
$endpoint = $this->build_endpoint();
$meta_name = '_' . self::STATS_CACHE_TRANSIENT_PREFIX;
$stats_cache = get_post_meta( $post_id, $meta_name, false );

if ( $stats_cache ) {
$data = reset( $stats_cache );

if (
! is_array( $data )
|| empty( $data )
|| is_wp_error( $data )
) {
return $data;
}

$time = key( $data );
$views = $data[ $time ] ?? null;

// Bail if data is malformed.
if ( ! is_numeric( $time ) || ! is_array( $views ) ) {
return $data;
}

/** This filter is already documented in projects/packages/stats/src/class-wpcom-stats.php */
$expiration = apply_filters(
'jetpack_fetch_stats_cache_expiration',
self::STATS_CACHE_EXPIRATION_IN_MINUTES * MINUTE_IN_SECONDS
);

if ( ( time() - $time ) < $expiration ) {
return array_merge( array( 'cached_at' => $time ), $views );
}
}
$endpoint = $this->build_endpoint();
$meta_name = '_' . self::STATS_CACHE_TRANSIENT_PREFIX;

$wpcom_stats = $this->fetch_remote_stats( $endpoint, $args );
update_post_meta( $post_id, $meta_name, array( time() => $wpcom_stats ) );
Expand Down