Skip to content

Add test coverage for post stats cache handling improvements #46235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 12 commits into
base: trunk
Choose a base branch
from
Draft

Add test coverage for post stats cache handling improvements #46235

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e0ceb39
Remove post stats cache
dognose24 Dec 5, 2025
8877038
changelog
dognose24 Dec 5, 2025
a736465
Improve post stats cache handling for invalid or error data
dognose24 Dec 5, 2025
ffe8c0c
Update changelog
dognose24 Dec 5, 2025
3c3624b
Merge branch 'trunk' into update/blog_stats_debug
dognose24 Dec 9, 2025
4ba2b0e
Respect the cache first and return errors or invalid data as they were
dognose24 Dec 9, 2025
68d3fe3
Keep WP errors from cache along with the valid response
dognose24 Dec 9, 2025
3bbe021
Update annotations
dognose24 Dec 9, 2025
5b9fc39
Update annotations
dognose24 Dec 9, 2025
94e3c06
Initial plan
Copilot Dec 9, 2025
93d7534
Add comprehensive test coverage for post stats cache handling
Copilot Dec 9, 2025
e80c38b
Fix test assertions to match actual WP_Error behavior
Copilot Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test assertions to match actual WP_Error behavior 
Co-authored-by: dognose24 <[email protected]>
  • Loading branch information
@dognose24
Copilot and dognose24 committed Dec 9, 2025
commit e80c38bc36c2a8e3ff47faa79a3c6e70bf0d1cad
8 changes: 6 additions & 2 deletions projects/packages/stats/tests/php/WPCOM_Stats_Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,10 +936,13 @@ public function test_fetch_post_stats_returns_cached_wp_error_within_expiration(

$stats = $this->wpcom_stats->get_post_views( $post_id, array(), true );

// Should return the cached WP_Error with cached_at timestamp.
// Should return the cached WP_Error as an array with cached_at timestamp.
// When a WP_Error is cached, it's converted to array and merged with cached_at.
$this->assertTrue( is_array( $stats ) );
$this->assertArrayHasKey( 'cached_at', $stats );
$this->assertSame( $time, $stats['cached_at'] );
// WP_Error properties are converted to array keys.
$this->assertArrayHasKey( 'errors', $stats );
}

/**
Expand Down Expand Up @@ -1045,8 +1048,9 @@ public function test_refresh_post_stats_cache_caches_error_response() {

$stats = $this->wpcom_stats->get_post_views( $post_id, array(), true );

// Should return the error.
// Should return the fresh WP_Error directly (not wrapped in array).
$this->assertTrue( is_wp_error( $stats ) );
$this->assertSame( 'stats_error', $stats->get_error_code() );

// Verify the error was cached.
$meta_name = '_' . WPCOM_Stats::STATS_CACHE_TRANSIENT_PREFIX;
Expand Down