Skip to content

Conversation

@CGastrell
Copy link
Contributor

@CGastrell CGastrell commented Dec 10, 2025

Part of FORMS-132

This is a revamp of #43821 , which was reverted with #46223
We now have #46254 (a revamp itself of #44538 ) and once that is merged, this is safe to follow.

Proposed changes:

  • Remove now unused admin class files from the Forms package
  • Delete class-admin.php (1610 lines) which handled legacy admin functionality
  • Delete class-form-view.php (289 lines) which was no longer needed
  • Clean up references in class-editor-view.php and class-util.php
  • Update Phan baseline to reflect the removed files

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Install and activate Jetpack with the Forms package
  • Go to /wp-admin/ and check that there are no PHP errors or warnings
  • Navigate to the Forms dashboard and verify it displays correctly
  • Test creating a new form to ensure Forms functionality works as expected
  • Check that existing forms continue to function properly

Specially:

  • test both export options (CSV & GDrive)
  • sync to simple sandboxed site, verify both exports there as well

@CGastrell CGastrell added [Status] Needs Review This PR is ready for review. [Type] Task [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Package] Forms Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR labels Dec 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the remove/contact-form-legacy-admin-files-2 branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack remove/contact-form-legacy-admin-files-2

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: January 6, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/contact-form/class-editor-view.php 0/156 (0.00%) 0.00% -1 💚
projects/packages/forms/src/contact-form/class-util.php 33/175 (18.86%) 0.21% -2 💚

Full summary · PHP report · JS report

Coverage check overridden by Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR .

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy admin class files from the Forms package as part of FORMS-132. The changes safely clean up 1,899 lines of code that are no longer needed after the modernization work completed in PR #46254.

Key Changes:

  • Deleted two legacy admin class files (class-admin.php and class-form-view.php)
  • Removed all references to the deleted classes from active code
  • Updated Phan baseline to remove suppressions for deleted files

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
class-admin.php Deleted 1,610-line legacy admin class that handled form builder UI, export functionality, and spam management
class-form-view.php Deleted 289-line legacy form builder view template
class-util.php Removed Admin::init() call that was conditionally loading the deleted admin class
class-editor-view.php Removed obsolete remove_action call referencing the deleted Admin class
.phan/baseline.php Removed suppressions for deleted class-admin.php file and updated issue statistics
changelog/remove-contact-form-legacy-admin-files Added changelog entry documenting the removal

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Review This PR is ready for review. [Type] Janitorial [Type] Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants