-
Notifications
You must be signed in to change notification settings - Fork 842
Remove contact form legacy admin files #46255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 2 files.
Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes legacy admin class files from the Forms package as part of FORMS-132. The changes safely clean up 1,899 lines of code that are no longer needed after the modernization work completed in PR #46254.
Key Changes:
- Deleted two legacy admin class files (
class-admin.phpandclass-form-view.php) - Removed all references to the deleted classes from active code
- Updated Phan baseline to remove suppressions for deleted files
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
class-admin.php |
Deleted 1,610-line legacy admin class that handled form builder UI, export functionality, and spam management |
class-form-view.php |
Deleted 289-line legacy form builder view template |
class-util.php |
Removed Admin::init() call that was conditionally loading the deleted admin class |
class-editor-view.php |
Removed obsolete remove_action call referencing the deleted Admin class |
.phan/baseline.php |
Removed suppressions for deleted class-admin.php file and updated issue statistics |
changelog/remove-contact-form-legacy-admin-files |
Added changelog entry documenting the removal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Part of FORMS-132
This is a revamp of #43821 , which was reverted with #46223
We now have #46254 (a revamp itself of #44538 ) and once that is merged, this is safe to follow.
Proposed changes:
class-admin.php(1610 lines) which handled legacy admin functionalityclass-form-view.php(289 lines) which was no longer neededclass-editor-view.phpandclass-util.phpOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
/wp-admin/and check that there are no PHP errors or warningsSpecially: