Social: Replace the resharing upgrade nudge with the core Notice component with action

[manzoorwanijk]

On Simple sites with a free plan, resharing is not available and an upgrade notice is shown. This notice does not use the Core Notice component. It rather uses some custom component.

Completes SOCIAL-275

Proposed changes:

• Replace the resharing upgrade nudge with the core Notice component with action
• Remove the unnecessary condition of resharing not being upgradable. Resharing has been made available to all sites except Simple free sites, and thus, this condition is no longer used.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Apply this PR to your sandbox
• Point your Simple site with a free plan to your sandbox along with the public API
• Edit an exisitng post on the site
• Open Jetpack sidebar
• Confirm that the resharing upgrade now shows the Notice instead of our own implementation.

Before	After

Note: The spacing for the core Notice has already been fixed in #69430 and should be automatically be available in the next Gutenber/Core release.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/social/resharing-upgrade-notice branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/social/resharing-upgrade-notice

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[Copilot]

Pull request overview

This PR refactors the Publicize resharing upgrade notice to use WordPress's core Notice component instead of a custom implementation, improving code maintainability and consistency.

Key Changes:

• Replaced custom upgrade notice with WordPress core Notice component with action button
• Removed the isRePublicizeUpgradableViaUpsell condition check from the UpsellNotice component (note: this property is still used in other components)
• Simplified the component logic by removing platform-specific rendering and external link documentation

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
projects/js-packages/publicize-components/src/components/panel/upsell.tsx	Refactored UpsellNotice component to use WordPress core Notice component with action button, removed custom markup, and simplified conditional logic
projects/js-packages/publicize-components/changelog/fix-social-resharing-upgrade-notice	Added changelog entry documenting the change as a patch-level update

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/js-packages/publicize-components/src/components/panel/upsell.tsx	0/9 (0.00%)	0.00%	-5 💚

Full summary · PHP report · JS report

[gmjuhasz]

It uses core now, altough that button looks a bit odd imo, I wonder if we could make it better 🤔

[manzoorwanijk]

I wonder if we could make it better

I already added a note to the PR about the improvement in Core for the spacing for those actions.