Forms: exclude unminified build artifacts from production distribution by kraftbj · Pull Request #47044 · Automattic/jetpack

kraftbj · 2026-02-10T18:27:57Z

See FORMS-582 (partial)

Proposed changes:

Replace the blanket build/** production-include in the forms package .gitattributes with explicit includes for *.php, *.min.js, and loader.js. This excludes unminified JS (~2.7 MB, ~61K lines) and source maps from the production distribution.
Add a SCRIPT_DEBUG fallback file (wp-build-script-debug-fallback.php) that predefines the wp-build auto-generated registration functions with file_exists checks, so SCRIPT_DEBUG=true gracefully falls back to .min.js when unminified files are absent.
Exclude /routes/** source files (TSX/TS/SCSS compiled into build/) from production.

How it works

The auto-generated PHP in build/ picks script extensions via:

$extension = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '.js' : '.min.js';

Without unminified files, SCRIPT_DEBUG=true would 404. The generated files all use function_exists() guards, so loading the fallback file before build.php predefines the functions with a safe version that checks file_exists() before choosing the unminified path.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Build the forms package: jp build projects/packages/forms --deps

Verify production file list:

cd projects/packages/forms
git check-attr production-include -- build/build.php build/scripts/theme/index.min.js build/pages/jetpack-forms-responses/loader.js
# All should show "production-include: set"

Verify unminified JS is excluded:

git check-attr production-include -- build/scripts/theme/index.js build/modules/boot/index.js build/routes/forms/content.js
# All should show "production-include: unspecified"

SCRIPT_DEBUG scenarios (conceptual, verifiable in a WP environment with the jetpack_forms_alpha filter enabled):
- SCRIPT_DEBUG=true + unminified files present (dev): loads .js
- SCRIPT_DEBUG=true + unminified files absent (production): loads .min.js
- SCRIPT_DEBUG=false: always loads .min.js

Replace the blanket `build/**` production-include in .gitattributes with explicit includes for *.php, *.min.js, and loader.js. This excludes unminified JS (~2.7 MB) and source maps from the production distribution. Add a SCRIPT_DEBUG fallback file that predefines the wp-build generated registration functions with file_exists checks, so SCRIPT_DEBUG=true gracefully falls back to .min.js when unminified files are absent. Also exclude /routes/** (source TSX/TS/SCSS compiled into build/).

github-actions · 2026-02-10T18:28:46Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-assets branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/forms-assets

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-02-10T18:28:58Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copilot

Pull request overview

This PR reduces the Forms package’s production footprint by tightening which build/ artifacts are included in production distributions, while adding a PHP fallback so SCRIPT_DEBUG=true doesn’t break when unminified assets are intentionally omitted.

Changes:

Narrow projects/packages/forms/.gitattributes production includes for build/ to *.php, *.min.js, and loader.js, and exclude /routes/** sources from production.
Add a wp-build SCRIPT_DEBUG fallback file that prefers unminified assets only when they actually exist.
Load the fallback file before build/build.php when the wp-build admin page is visited.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
projects/packages/forms/src/dashboard/wp-build-script-debug-fallback.php	Adds SCRIPT_DEBUG-safe registration helpers that fall back to `.min.js`/`.min.css` when unminified files are missing.
projects/packages/forms/src/dashboard/class-dashboard.php	Loads the fallback file before wp-build’s generated `build.php` on the wp-build admin page.
projects/packages/forms/changelog/update-forms-assets	Documents the production distribution change.
projects/packages/forms/.gitattributes	Restricts which build artifacts are shipped to production and excludes `/routes/**` sources.

projects/packages/forms/src/dashboard/wp-build-script-debug-fallback.php

jp-launch-control · 2026-02-10T18:39:34Z

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/dashboard/class-dashboard.php	59/200 (29.50%)	1.86%	-3 💚

1 file is newly checked for coverage.

File	Coverage
projects/packages/forms/src/dashboard/wp-build-script-debug-fallback.php	0/137 (0.00%) 💔

Full summary · PHP report · JS report

_{Coverage check overridden by

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
.}

- Use defined( 'SCRIPT_DEBUG' ) guard for $default_version in scripts and styles registration to avoid PHP 8+ fatal on undefined constant. - Remove remove_action( 'wp_default_scripts', 'wp_default_script_modules' ) which was incorrectly copied from the template — our fallback should not prevent core from registering its default script modules.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

projects/packages/forms/.gitattributes

projects/packages/forms/src/dashboard/wp-build-script-debug-fallback.php

projects/packages/forms/src/dashboard/class-dashboard.php

… WP 6.8 compat - Add /build/**/*.min.css and /build/**/*.rtl.css to .gitattributes production-include so CSS build artifacts ship in production. - Add ABSPATH guard to wp-build-script-debug-fallback.php. - Move $default_version after extension/suffix detection so minified fallback files use the stable build version instead of time(). - Remove 5th arg from wp_register_script_module() (added in WP 6.9, but Jetpack supports 6.8). - Add unit tests for Dashboard::load_wp_build().

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

projects/packages/forms/tests/php/dashboard/Dashboard_Test.php

projects/packages/forms/src/dashboard/wp-build-script-debug-fallback.php

projects/packages/forms/src/dashboard/class-dashboard.php

projects/packages/forms/tests/php/dashboard/Dashboard_Test.php

The load_wp_build tests were using assertions that could never fail: function_exists() for a function that never exists, and assertTrue(true). Replace with has_action('wp_default_scripts', ...) to verify the actual observable side effect of loading the fallback file. Skip the missing-build test locally when build/ exists to avoid false positives.

anomiex · 2026-02-11T17:04:02Z

This excludes unminified JS (~2.7 MB, ~61K lines)

Why is the production build building unminified JS in the first place?

and source maps

For i18n purposes¹ and client-side debugging, someday it would probably be nice to start distributing source maps for all our JS. The down side, though, is that (last I checked, p1726069454468079-slack-C05Q5HSS013) it would increase the on-disk size of Jetpack by something like 30M, which seems likely to draw more "bloat" complaints.

translate.wordpress.org can read i18n strings and translator comments from source maps, and letting it do so would probably have fewer problems than our current approach of trying to keep them recognizable in minified JS. ↩

kraftbj · 2026-02-11T18:21:25Z

Why is the production build building unminified JS in the first place?

That I don't know, tbh.
@simison - is there a reason for that beyond it's what wp-build does?

projects/packages/forms/src/dashboard/class-dashboard.php

dhasilva · 2026-02-11T23:18:34Z

Tested locally and did not notice any regression. Nice to see the Gutenberg PR as well!

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

projects/packages/forms/src/dashboard/wp-build-script-debug-fallback.php

projects/packages/forms/tests/php/dashboard/Dashboard_Test.php

kraftbj · 2026-02-17T17:25:10Z

@simison - would you be fine with shipping this for Jetpack while the larger wp-build discussion continues?

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

projects/packages/forms/src/dashboard/wp-build-script-debug-fallback.php

Copilot AI review requested due to automatic review settings February 10, 2026 18:27

kraftbj added the [Status] Needs Review This PR is ready for review. label Feb 10, 2026

kraftbj self-assigned this Feb 10, 2026

github-actions bot added [Feature] Forms [Package] Forms labels Feb 10, 2026

Copilot started reviewing on behalf of kraftbj February 10, 2026 18:28 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

kraftbj requested a review from Copilot February 10, 2026 18:48

Copilot started reviewing on behalf of kraftbj February 10, 2026 18:49 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

github-actions bot added the [Tests] Includes Tests label Feb 10, 2026

kraftbj requested a review from Copilot February 10, 2026 20:02

Copilot started reviewing on behalf of kraftbj February 10, 2026 20:03 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

simison reviewed Feb 11, 2026

View reviewed changes

projects/packages/forms/src/dashboard/class-dashboard.php Show resolved Hide resolved

simison requested review from dhasilva and youknowriad February 11, 2026 18:33

kraftbj added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Feb 12, 2026

kraftbj mentioned this pull request Feb 12, 2026

wp-build: Add --no-script-debug flag to skip debug assets WordPress/gutenberg#75396

Open

Merge remote-tracking branch 'origin/trunk' into update/forms-assets

8ce71c8

Copilot AI review requested due to automatic review settings February 12, 2026 17:33

Copilot started reviewing on behalf of kraftbj February 12, 2026 17:33 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

projects/packages/forms/src/dashboard/wp-build-script-debug-fallback.php Show resolved Hide resolved

projects/packages/forms/tests/php/dashboard/Dashboard_Test.php Show resolved Hide resolved

Merge remote-tracking branch 'origin/trunk' into update/forms-assets

5f64132

kraftbj requested a review from Copilot February 17, 2026 17:24

Copilot started reviewing on behalf of kraftbj February 17, 2026 17:24 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

Conversation

kraftbj commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

How it works

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jp-launch-control bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anomiex commented Feb 11, 2026

Footnotes

Uh oh!

kraftbj commented Feb 11, 2026

Uh oh!

Uh oh!

dhasilva commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

kraftbj commented Feb 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kraftbj commented Feb 10, 2026 •

edited

Loading

github-actions bot commented Feb 10, 2026 •

edited

Loading

jp-launch-control bot commented Feb 10, 2026 •

edited

Loading