Jetpack pages: Adjust maximum container width to 1040px#47350
Jetpack pages: Adjust maximum container width to 1040px#47350
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Super Cache plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage Summary1 file is newly checked for coverage.
Full summary · PHP report · JS report Coverage check overridden by
I don't care about code coverage for this PR
|
f886f1a to
181eecc
Compare
There was a problem hiding this comment.
Pull request overview
Standardizes admin UI container sizing by updating various Jetpack-related products/packages to use a 1040px maximum content width (replacing 1128px and other widths), with some related layout refinements (notably in My Jetpack tab panel/footer rendering).
Changes:
- Reduced max container widths to 1040px across several plugins/packages (Jetpack, Boost, Super Cache, IDC, shared components/base styles, My Jetpack).
- Refactored My Jetpack tab panel footer rendering to use a shared footer wrapper component and updated full-width background styling.
- Added changelog entries across impacted projects/packages.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/plugins/super-cache/styling/dashboard.css | Updates --max-container-width to 1040px for Super Cache admin UI. |
| projects/plugins/super-cache/changelog/ui-max-width-1040px-all-pages | Changelog entry for Super Cache UI width update. |
| projects/plugins/jetpack/changelog/ui-max-width-1040px-all-pages | Changelog entry for Jetpack UI width update. |
| projects/plugins/jetpack/_inc/client/scss/shared/_main.scss | Aligns Jetpack shared containers to 1040px and adjusts responsive breakpoint. |
| projects/plugins/boost/changelog/ui-max-width-1040px-all-pages | Changelog entry for Boost UI width update. |
| projects/plugins/boost/app/assets/src/js/layout/footer/footer.module.scss | Minor footer signature spacing adjustment. |
| projects/plugins/boost/app/assets/src/css/main/dashboard.scss | Updates Boost container sizing/padding and container max width calculation. |
| projects/packages/my-jetpack/changelog/ui-max-width-1040px-all-pages | Changelog entry for My Jetpack UI width update. |
| projects/packages/my-jetpack/_inc/components/product-interstitial/_mixins.scss | Aligns product interstitial wrappers to 1040px. |
| projects/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/styles.module.scss | Adjusts tab panel layout and introduces full-width background treatments. |
| projects/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/overview/styles.module.scss | Removes now-redundant overview footer styles (moved to shared footer). |
| projects/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/overview/content.tsx | Switches overview footer markup to shared MyJetpackTabPanelFooter. |
| projects/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/index.tsx | Wraps tab panel in layout Container/Col for consistent width behavior. |
| projects/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/help/styles.module.scss | Removes old footer container styles; keeps header typography as a class. |
| projects/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/help/footer.tsx | Refactors Help footer to use shared MyJetpackTabPanelFooter. |
| projects/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/footer.tsx | Introduces shared footer wrapper component. |
| projects/packages/my-jetpack/_inc/components/my-jetpack-screen/styles.module.scss | Removes page-header padding overrides. |
| projects/js-packages/idc/components/idc-screen/style.scss | Updates IDC screen sizing to 1040px and replaces left border with pseudo-element. |
| projects/js-packages/idc/changelog/ui-max-width-1040px-all-pages | Changelog entry for IDC UI width update. |
| projects/js-packages/components/components/jetpack-footer/style.scss | Updates shared Jetpack footer max width to 1040px. |
| projects/js-packages/components/changelog/ui-max-width-1040px-all-pages | Changelog entry for components UI width update. |
| projects/js-packages/base-styles/style.scss | Aligns base-styles grid max width to 1040px (tablet-up). |
| projects/js-packages/base-styles/changelog/ui-max-width-1040px-all-pages | Changelog entry for base-styles UI width update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
projects/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/styles.module.scss
Show resolved
Hide resolved
projects/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/styles.module.scss
Show resolved
Hide resolved
|
@ederrengifo @keoshi @grbicsanja @ilonagl - looping you all in for design input. I've attached a recording for before (black) / after (red) comparisons of the My Jetpack screens. jetpack-widths.mp4 |
Closes DOTCOM-16126.
Proposed changes
My Jetpack
My Jetpack Instertitial (
/admin.php?page=my-jetpack#/jetpack-aiandadmin.php?page=my-jetpack#/protect-details)Jetpack Dashboard / Settings
Jetpack Vaultpress Backup
Jetpack product discussion
p1771956593002369-slack-C0AGM2YP9GW.
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Apply this Jetpack build to your Simple and Atomic sites and review the changes indicated above, ensuring the page contents are 1040px wide and narrow as the screen gets smaller.
You'll need to install Jetpack Beta Tester and activate the beta for Jetpack, Jetpack Backup and Jetpack Boost.
Changelog