admin-ui: Add Upgrade to Pro menu item for free users #47418
Update BackupNowButton propTypes to include new variant options
Changed the variant prop in the BackupNowButton component from 'primary', 'secondary', 'tertiary' to 'solid', 'outline', 'minimal', 'unstyled' for improved flexibility in button styling.
- Loading branch information
commit 10b8090fd230d411e399272222ae41e23b1ceb04
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,7 +107,7 @@ BackupNowButton.propTypes = { | |
| children: PropTypes.node, | ||
| tooltipText: PropTypes.string, | ||
| tracksEventName: PropTypes.string, | ||
| variant: PropTypes.oneOf( [ 'solid', 'outline', 'minimal', 'unstyled' ] ), | ||
| onClick: PropTypes.func, | ||
| }; | ||
|
Comment on lines
106
to
112
There was a problem hiding this comment. PropTypes for |
||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
variantPropTypes were changed to[ 'solid', 'outline', 'minimal', 'unstyled' ], but other code in this package already passesvariant="primary"/variant="tertiary"to buttons. This will produce PropTypes warnings and suggests the accepted values don't match actual usage. Either expand the allowed values to include the variants you use in this repo, or update the callers and confirm the WPButtonvariant API supports the new set.