Skip to content

Create separate generic for schema definition #13856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Create separate generic for schema definition #13856

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b125a0
WIP alternative approach for #13523: create separate generic for sche…
vkarpov15 Sep 1, 2023
6830fc0
types: fixed all but one TS test
vkarpov15 Sep 12, 2023
5858061
clean up all but 1 test
vkarpov15 Sep 12, 2023
0e77ec9
test: quick tweak
vkarpov15 Sep 12, 2023
f61b834
Merge branch '8.0' into vkarpov15/gh-13523-2
vkarpov15 Sep 25, 2023
18ee0eb
quick fixes
vkarpov15 Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
quick fixes
  • Loading branch information
@vkarpov15
vkarpov15 committed Sep 25, 2023
commit 18ee0eb411464a98ee3bc941a2d9bb167a2f3f77
28 changes: 20 additions & 8 deletions test/types/schema.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,8 +1014,8 @@ function gh12869() {

const dbExample = new Schema(
{
active: { type: String, enum: ['foo', 'bar'] as ['foo', 'bar'], required: true }
}
active: { type: String, enum: ['foo', 'bar'], required: true }
} as const
);

type Example = InferSchemaType<typeof dbExample>;
Expand Down Expand Up @@ -1247,10 +1247,22 @@ async function gh13797() {
interface IUser {
name: string;
}
new Schema<IUser>({ name: { type: String, required: function() {
expectType<IUser>(this); return true;
} } });
new Schema<IUser>({ name: { type: String, default: function() {
expectType<IUser>(this); return '';
} } });
new Schema<IUser>({
name: {
type: String,
required: function() {
expectType<IUser>(this);
return true;
}
}
});
new Schema<IUser>({
name: {
type: String,
default: function() {
expectType<IUser>(this);
return '';
}
}
});
}