fix(query): shallow clone $or, $and if merging onto empty query filter #14580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (isPOJO(from[key])) { | ||
| to[key] = { ...from[key] }; | ||
| } else { | ||
| to[key] = from[key]; |
Check warning
Code scanning / CodeQL
Prototype-polluting function
sderrow
reviewed
May 9, 2024
Contributor
sderrow
left a comment
sderrow
left a comment
There was a problem hiding this comment.
Thanks! Just a couple thoughts.
Co-authored-by: Sean Derrow <[email protected]>
Co-authored-by: Sean Derrow <[email protected]>
2 tasks
vkarpov15
added a commit
that referenced
this pull request
May 24, 2024
This was referenced Jun 5, 2024
This was referenced Jun 22, 2024
This was referenced Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14567
Summary
Currently, when you call
TestModel.find({ $and }), Mongoose doesn't clone the$and. ThenQuery.prototype.and()usespush()to add onto the$andarray, which modifies the existing$andarray.We already have some logic in place from #12944 that shallow clones $and, $or if they're set, but that only currently kicks in if there's an existing
$and/$or. With this PR, we'll do a shallow clone on$and,$orif they exist on the user's provided query filter.Examples