Skip to content

fix(model): make bulkWrite() and insertMany() throw if throwOnValidationError set and all ops invalid #14587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2024
Merged

fix(model): make bulkWrite() and insertMany() throw if throwOnValidationError set and all ops invalid #14587

merged 1 commit into from
May 17, 2024

Conversation

@vkarpov15
Copy link
Collaborator

@vkarpov15 vkarpov15 commented May 12, 2024

Fix #14572

Summary

Right now we have a throwOnValidationError that means bulkWrite() and insertMany() will throw if any operations fail validation... except if all operations fail validation. This PR makes it so that we still throw a MongooseBulkWriteError if all operations fail validation.

Examples

@vkarpov15 vkarpov15 mentioned this pull request May 12, 2024
Closed
2 tasks
vkarpov15 added a commit that referenced this pull request May 16, 2024
@vkarpov15
feat(model): add throwOnValidationError option for opting into gettin…
f4cfe1e 
…g MongooseBulkWriteError if all valid operations succeed in bulkWrite() and insertMany()

Backport #13410
Backport #14587
Fix #14572
@vkarpov15 vkarpov15 mentioned this pull request May 16, 2024
Merged
@vkarpov15 vkarpov15 added this to the 8.4 milestone May 17, 2024
@vkarpov15 vkarpov15 merged commit cdedde6 into master May 17, 2024
@hasezoey hasezoey deleted the vkarpov15/gh-14572 branch May 17, 2024 11:37
@nejidevelops nejidevelops mentioned this pull request Jun 7, 2024
Open
@carltrepanier carltrepanier mentioned this pull request Jun 7, 2024
Merged
@lholmquist lholmquist mentioned this pull request Jun 7, 2024
Closed
@NotZarifGithub NotZarifGithub mentioned this pull request Jun 7, 2024
Open
@PatF3lix PatF3lix mentioned this pull request Jun 7, 2024
Open
This was referenced Jun 7, 2024
Open
Open
@akanchhaS akanchhaS mentioned this pull request Jun 8, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Jun 8, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 8, 2024
Open
@DulranS DulranS mentioned this pull request Jun 8, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Jun 8, 2024
Open
@mihirhbhatt mihirhbhatt mentioned this pull request Jun 8, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Jun 8, 2024
Open
@astitva3110 astitva3110 mentioned this pull request Jun 8, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Jun 8, 2024
Merged
@tuanicom tuanicom mentioned this pull request Jun 8, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Jun 9, 2024
Open
@aswanthchandran0 aswanthchandran0 mentioned this pull request Jun 9, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 10, 2024
Open
@DulranS DulranS mentioned this pull request Jun 22, 2024
Open
@LunarArtemis LunarArtemis mentioned this pull request Jun 22, 2024
Open
@javascript-benchmark javascript-benchmark mentioned this pull request Jun 22, 2024
Open
@lholmquist lholmquist mentioned this pull request Jun 22, 2024
Closed
@Erenkrs Erenkrs mentioned this pull request Jun 22, 2024
Open
@carltrepanier carltrepanier mentioned this pull request Jun 22, 2024
Merged
@nay0101 nay0101 mentioned this pull request Jun 23, 2024
Closed
@yunji0387 yunji0387 mentioned this pull request Jun 23, 2024
Merged
@darshanthind darshanthind mentioned this pull request Jun 23, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 24, 2024
Open
@bukhosi-eugene-mpande bukhosi-eugene-mpande mentioned this pull request Jun 25, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Jun 25, 2024
Open
@mihirhbhatt mihirhbhatt mentioned this pull request Jun 26, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Jun 26, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Jun 26, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Jun 27, 2024
Open
@koushikpuppala koushikpuppala mentioned this pull request Jun 28, 2024
Closed
@akanchhaS akanchhaS mentioned this pull request Jun 28, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 28, 2024
Open
@AllanYuen AllanYuen mentioned this pull request Jun 28, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 29, 2024
Open
@nushydude nushydude mentioned this pull request Jun 29, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 30, 2024
Open
@McDeCoderDude McDeCoderDude mentioned this pull request Jul 1, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Jul 1, 2024
Open
@shristi9800 shristi9800 mentioned this pull request Jul 1, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jul 2, 2024
Open
@BenedictionL BenedictionL mentioned this pull request Jul 4, 2024
Open
This was referenced Jul 4, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.4

Development

Successfully merging this pull request may close these issues.

bulkWrite does not throw an error if all documents are invalid (ordered: false)

3 participants

@vkarpov15 @hasezoey