Skip to content

perf: avoid unnecesary get() call and use faster approach for converting to string #14673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2024
Merged

perf: avoid unnecesary get() call and use faster approach for converting to string #14673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2991d7b
perf: avoid unnecesary get() call and use faster approach for convert…
vkarpov15 Jun 17, 2024
20d1500
fix tests
vkarpov15 Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/document.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4066,7 +4066,8 @@ Document.prototype.toObject = function(options) {

function applyVirtuals(self, json, options, toObjectOptions) {
const schema = self.$__schema;
const paths = Object.keys(schema.virtuals);
const virtuals = schema.virtuals;
const paths = Object.keys(virtuals);
let i = paths.length;
const numPaths = i;
let path;
Expand Down Expand Up @@ -4117,7 +4118,7 @@ function applyVirtuals(self, json, options, toObjectOptions) {
assignPath = path.substring(options.path.length + 1);
}
if (assignPath.indexOf('.') === -1 && assignPath === path) {
v = self.get(path, null, { noDottedPath: true });
v = virtuals[path].applyGetters(void 0, self);
v = clone(v, options);
if (v === void 0) {
continue;
Expand Down
2 changes: 1 addition & 1 deletion lib/helpers/schema/idGetter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ module.exports = function addIdGetter(schema) {

function idGetter() {
if (this._id != null) {
return String(this._id);
return this._id.toString();
}

return null;
Expand Down
5 changes: 2 additions & 3 deletions test/document.unit.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,11 @@ describe('toObject()', function() {

beforeEach(function() {
Stub = function() {
const schema = this.$__schema = {
this.$__schema = {
options: { toObject: { minimize: false, virtuals: true } },
virtuals: { virtual: 'test' }
virtuals: { virtual: { applyGetters: () => 'test' } }
};
this._doc = { empty: {} };
this.get = function(path) { return schema.virtuals[path]; };
this.$__ = {};
};
Stub.prototype = Object.create(mongoose.Document.prototype);
Expand Down