Skip to content

fix(query): remove count() and findOneAndRemove() from query chaining #14692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 1, 2024
Merged

fix(query): remove count() and findOneAndRemove() from query chaining #14692

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
758eca3
fix(document): avoid passing validateModifiedOnly to subdocs so subdo…
vkarpov15 Jun 24, 2024
36ea383
fix(projection): handle projections on arrays in `Model.hydrate()` pr…
vkarpov15 Jun 24, 2024
091c85d
fix: handle casting primitive array with $elemMatch in bulkWrite()
vkarpov15 Jun 24, 2024
561a580
test: add type test for Connection.withSession
apparedev Jun 25, 2024
cc63f69
feat: fix return type of Connection.withSession
apparedev Jun 25, 2024
8b05872
style: fix lint
vkarpov15 Jun 25, 2024
c062b1f
Merge pull request #14685 from Automattic/vkarpov15/gh-14677
vkarpov15 Jun 25, 2024
516464a
Merge pull request #14686 from Automattic/vkarpov15/gh-14680
vkarpov15 Jun 25, 2024
31111f2
Merge pull request #14687 from Automattic/vkarpov15/gh-14678
vkarpov15 Jun 25, 2024
f89868b
Merge pull request #14690 from tt-public/feat/type-withsession
vkarpov15 Jun 25, 2024
6136846
fix(query): remove `count()` and `findOneAndRemove()` from query chai…
vkarpov15 Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/types/connection.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ expectType<Promise<void>>(conn.transaction(async(res) => {
return 'a';
}, { readConcern: 'majority' }));

expectType<Promise<string>>(conn.withSession(async(res) => {
expectType<mongodb.ClientSession>(res);
return 'a';
}));

expectError(conn.user = 'invalid');
expectError(conn.pass = 'invalid');
expectError(conn.host = 'invalid');
Expand Down
2 changes: 1 addition & 1 deletion types/connection.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ declare module 'mongoose' {
/** Watches the entire underlying database for changes. Similar to [`Model.watch()`](/docs/api/model.html#model_Model-watch). */
watch<ResultType extends mongodb.Document = any>(pipeline?: Array<any>, options?: mongodb.ChangeStreamOptions): mongodb.ChangeStream<ResultType>;

withSession<T = any>(executor: (session: ClientSession) => Promise<T>): T;
withSession<T = any>(executor: (session: ClientSession) => Promise<T>): Promise<T>;
}

}