Skip to content

Avoid leaving subdoc defaults on top-level doc when setting subdocument to same value #14728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Avoid leaving subdoc defaults on top-level doc when setting subdocument to same value #14728

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9f6591
proof of concept for cleaning up dangling defaults on unmodified subd…
vkarpov15 Jul 5, 2024
f28514e
fix(document): avoid leaving subdoc defaults on top-level doc when se…
vkarpov15 Jul 5, 2024
2a83e26
Merge branch 'master' into vkarpov15/gh-14722
vkarpov15 Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
proof of concept for cleaning up dangling defaults on unmodified subd… 
…ocuments re: #14722
  • Loading branch information
@vkarpov15
vkarpov15 committed Jul 5, 2024
commit c9f6591d9947eba1a9b09fff58b949e58e8bf12e
7 changes: 7 additions & 0 deletions lib/document.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1691,6 +1691,13 @@ Document.prototype.$__set = function(pathToMark, path, options, constructing, pa
}
});
}
} else if (schema && schema.instance === 'Embedded') {
const defaultPaths = Object.keys(this.$__.activePaths.states['default'] ?? {});
for (const defaultPath of defaultPaths) {
if (defaultPath.startsWith(path + '.')) {
this.$__.activePaths.clearPath(defaultPath);
}
}
}

let obj = this._doc;
Expand Down