-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
feat(model+query): support options parameter for distinct()
#14772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the options parameter still needs to be added to the query types (currently only in the model's types) and a similar test to using options parameter for distinct on query should likely be in for Model too, or is the transaction test enough?
As a note, the Model.distinct and Query.prototype.distinct have differing options checks, is this intentional?
Co-authored-by: hasezoey <[email protected]>
…ments(), estimatedDocumentCount(), distinct()
|
Thanks for the suggestions @hasezoey , I've implemented them both. Added |
Fix #8006
Summary
Make it easier to use
distinct()with transactions, so you don't need to chainsetOptions().distinct()looks to be the only query function where you can't pass inoptions.Examples