Skip to content

fix(connection): avoid returning readyState = connected if connection state is stale #14812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix(connection): avoid returning readyState = connected if connection state is stale #14812

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06839fa
fix(connection): avoid returning `readyState = connected` if connecti…
vkarpov15 Aug 17, 2024
86fea93
fix: dont treat failed heartbeat as heartbeat
vkarpov15 Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: dont treat failed heartbeat as heartbeat
  • Loading branch information
@vkarpov15
vkarpov15 committed Sep 17, 2024
commit 86fea9341f824d3c72303c51c3b091f6ef4f9c3c
3 changes: 0 additions & 3 deletions lib/drivers/node-mongodb-native/connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,9 +418,6 @@ function _setClient(conn, client, options, dbName) {
client.on('serverHeartbeatSucceeded', () => {
conn._lastHeartbeatAt = Date.now();
});
client.on('serverHeartbeatFailed', () => {
conn._lastHeartbeatAt = Date.now();
});

if (options.monitorCommands) {
client.on('commandStarted', (data) => conn.emit('commandStarted', data));
Expand Down