Skip to content

fix(model): filter applying static hooks by default if static name conflicts with mongoose middleware #14908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2024
Merged

fix(model): filter applying static hooks by default if static name conflicts with mongoose middleware #14908

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8655c6c
fix(model): skip applying static hooks by default if static name conf…
dragontaek-lee Sep 24, 2024
c647a05
fix(model): skip applying static hooks by default if static name conf…
dragontaek-lee Sep 24, 2024
a06debe
fix: remove redundant async
dragontaek-lee Sep 24, 2024
1f7c742
Update applyStaticHooks.js
vkarpov15 Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update applyStaticHooks.js
  • Loading branch information
@vkarpov15
vkarpov15 authored Sep 25, 2024
commit 1f7c742c31e9763ca4ffa65bbd799d46aba81d57
8 changes: 4 additions & 4 deletions lib/helpers/model/applyStaticHooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
const promiseOrCallback = require('../promiseOrCallback');
const { queryMiddlewareFunctions, aggregateMiddlewareFunctions, modelMiddlewareFunctions, documentMiddlewareFunctions } = require('../../constants');

const middlewareFunctions = [
...[
const middlewareFunctions = Array.from(
new Set([
...queryMiddlewareFunctions,
...aggregateMiddlewareFunctions,
...modelMiddlewareFunctions,
...documentMiddlewareFunctions
].reduce((s, hook) => s.add(hook), new Set())
];
])
);

module.exports = function applyStaticHooks(model, hooks, statics) {
const kareemOptions = {
Expand Down