fix: rename blockVisibility to visibility

[laurelfulford]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

In #1968, we hid the new 'Hide' option for blocks in the Newsletter posts since the blocks weren't hidden in the sent newsletters.

In WordPress/gutenberg#73432, the support was renamed from blockVisibility to visibility to avoid clashes with the Block Visibility plugin; this caused our fix to stop working.

This PR updates the name to match.

How to test the changes in this Pull Request:

1. Follow the test steps in fix: remove 'hide block' option for Newsletters #1968 on a site running WP 6.9 and confirm that the 'Hide' option doesn't appear in the block toolbar.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.80%. Comparing base (ef4128e) to head (de18d64).
⚠️ Report is 6 commits behind head on release.

Additional details and impacted files

@@            Coverage Diff             @@
##             release    #1991   +/-   ##
==========================================
  Coverage      24.80%   24.80%           
  Complexity      2926     2926           
==========================================
  Files             50       50           
  Lines          10355    10355           
==========================================
  Hits            2569     2569           
  Misses          7786     7786           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[dkoo]

Works!

[laurelfulford]

Thanks @dkoo!

As an aside, I spent hours trying to figure out why the same setting wasn't working in the Newspack Plugin before I stumbled across the name change... 😆

[matticbot]

🎉 This PR is included in version 3.25.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀