feat(init-modal): apply new modal style to init screen in editor#2041
Merged
thomasguillot merged 1 commit intotrunkfrom Mar 2, 2026
Merged
feat(init-modal): apply new modal style to init screen in editor#2041thomasguillot merged 1 commit intotrunkfrom
thomasguillot merged 1 commit intotrunkfrom
Conversation
Contributor
|
It works as expected. But I have to say I don't love it. The fake full screen looks better :) |
leogermani
approved these changes
Feb 27, 2026
github-actions
bot
added
[Status] Approved
|
Hey @thomasguillot, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
matticbot
pushed a commit
that referenced
this pull request
Mar 5, 2026
# [3.29.0-alpha.1](v3.28.6...v3.29.0-alpha.1) (2026-03-05) ### Bug Fixes * iframe editor compatibility ([#2025](#2025)) ([cd15c02](cd15c02)) * improve error handling in upsert contact method ([#2031](#2031)) ([89a5937](89a5937)) * no parallel post-release jobs ([#2037](#2037)) ([8e4a738](8e4a738)) ### Features * **init-modal:** apply new modal style to init screen in editor ([#2041](#2041)) ([3caafdc](3caafdc))
|
🎉 This PR is included in version 3.29.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
WordPress recently updated the Editor Post Header height from 60px to 64px, which caused the Init modal to appear slightly misaligned. This is not the first time this modal has had issues. It was originally styled to simulate a full-screen experience, making it fragile and prone to breaking when upstream changes occur.
This PR refactors the Init modal to render as a standard "fill" Modal, bringing it in line with conventional modal behaviour. This approach is more resilient to future WordPress Editor changes and reduces the risk of layout regressions.
How to test the changes in this Pull Request:
Other information: