Skip to content

Replace timer with Task #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Replace timer with Task #3019

wants to merge 2 commits into from

Conversation

@bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Apr 18, 2025

Avoids threading issues with TimedActionHelper.

To test

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus
Replace timer with dispatch after
44925d4 
I think there are some thread safety issues with the TimedActionHelper implementation being triggered by the background queue use.
@bjtitus bjtitus requested a review from a team as a code owner April 18, 2025 15:48
@bjtitus bjtitus requested review from danielebogo and removed request for a team April 18, 2025 15:48
@dangermattic
Copy link
Collaborator

dangermattic commented Apr 18, 2025

1 Error
🚫 PR requires at least one label.
1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@bjtitus bjtitus changed the title Replace timer with dispatch after Replace timer with Task Apr 18, 2025
@bjtitus bjtitus marked this pull request as draft April 18, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielebogo danielebogo Awaiting requested review from danielebogo danielebogo is a code owner automatically assigned from Automattic/pocket-casts-ios

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bjtitus @dangermattic