This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Unnested blockbase post-content blocks from parent layouts #4253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbking
commented
Jul 19, 2021
| @@ -1,4 +1,4 @@ | |||
| <!-- wp:template-part {"slug":"header","tagName":"header","layout":{"inherit":true}} /--> | |||
| <!-- wp:template-part {"slug":"header","tagName":"header"} /--> | |||
Contributor
Author
There was a problem hiding this comment.
This I think was an unrelated change, but was discovered while scrutinizing the layout properties in the templates. This particular change just makes the markup of all usages of the header template part the same.
Closed
7 tasks
pbking
force-pushed
the
fix/blockbase-nested-layouts
branch
from
ba4d58b to
76148c2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This change ensures that all instances of post-content blocks have
{"layout":{"inherit":true}}and are the TOPMOST container that has{"layout":{"inherit":true}}applied.The post editor assumes the above situation (and is USUALLY correct). This change adjusts all templates in the theme so that it can be correct in the assumption 100% of the time.
Related issue(s):
Addresses: #4239
An alternative to: #4240
Relevant discussion in this issue: WordPress/gutenberg#33501