This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Blockbase + co: Fix navigation alignment #4795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
In my testing this works fine on dotcom, so we don't need to to wait for the next GB release... |
Contributor
Author
You are totally right! we can merge then |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
After WordPress/gutenberg#35077 was merged the navigation for Blockbase, Quadrat, Geologist, and Videomaker were broken. This PR fixes this by applying the alignment correctly in the block markup and removing the unused CSS. The rest of the children were behaving correctly.
Before:
After:
We need to hold on to this PR before we merge because dotcom doesn't have the GB just yet.