This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Remove/child theme #4861
Merged
Remove/child theme #4861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
reviewed
Oct 19, 2021
| @@ -1,5 +1,21 @@ | |||
| { | |||
| "customTemplates": [ | |||
| { | |||
Member
There was a problem hiding this comment.
I feel like this should also be part of the child/parent inheritance in Gutenberg
scruffian
approved these changes
Oct 19, 2021
Member
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
LGTM. I think it would be interesting to explore moving our SASS to CSS too, to totally remove the need for a build
Contributor
we would need to move things like the extra button styles to a separate stylesheet then |
… re-defined the now missing custom templates items in the themes that would now lack them
scruffian
force-pushed
the
remove/child-theme
branch
from
2cf7684 to
aac77df
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created as an alternative to #4807
This change:
Copies the Custom Templates portion to any themes that don't have them. (Our build script made an exception for that collection that Gutenberg doesn't.
Removes the JSON merging step from Blockbase and all children.
Modifies the
rebuild-child-themes.shtool to copychild-theme.jsontotheme.jsonfor all child themes.This modification is done in a script so that this change can sit at-the-ready until all environments are ready to accept this change and won't (or at least, isn't likely to) conflict with any
child-theme.jsonmade prior to that readyness. To execute run./rebuild-child-themes.sh(then delete that file) and then commit THOSE changes in the change as well. (But only when it's time to ship!)