Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Conversation

@MaggieCabrera
Copy link
Contributor

Changes proposed in this Pull Request:

This PR includes styles variations to Skatepark. Remember there's a bug in the editor where duotone filters won't display and it will look like the featured image/cover on the home page is missing.

Screenshot 2022-03-29 at 16 18 48

Screenshot 2022-03-29 at 16 18 01

@MaggieCabrera MaggieCabrera self-assigned this Mar 29, 2022
@MaggieCabrera MaggieCabrera added the [Theme] Skatepark Automatically generated label for Skatepark. label Mar 29, 2022
@MaggieCabrera MaggieCabrera requested a review from kjellr March 29, 2022 14:21
@MaggieCabrera MaggieCabrera added Do NOT merge! [Status] Needs Design Approval This task needs a designer to approve the changes before it can be merged or marked complete. labels Mar 29, 2022
Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to work well in my testing!

styles

"title": "Blue",
"settings": {
"color": {
"duotone": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but the indentation for the duotone styles looks weird in many of these.

@beafialho
Copy link
Collaborator

This also looks good to me!

@beafialho
Copy link
Collaborator

Closing this as it appears to be solved in #5415

@beafialho beafialho closed this Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Do NOT merge! [Status] Needs Design Approval This task needs a designer to approve the changes before it can be merged or marked complete. [Theme] Skatepark Automatically generated label for Skatepark.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants