Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Revert "Allow Jetpack to register fonts that Blockbase has not." #6788

Merged
madhusudhand merged 1 commit into from
Dec 20, 2022
Merged

Revert "Allow Jetpack to register fonts that Blockbase has not." #6788

madhusudhand merged 1 commit into from
Dec 20, 2022

Conversation

@madhusudhand
Copy link
Contributor

@madhusudhand madhusudhand commented Dec 20, 2022

Reverts #6777

Reverting this change as per the discussion p1670342089066579-slack-C029FM1EH

@madhusudhand madhusudhand merged commit 897a785 into trunk Dec 20, 2022
@madhusudhand madhusudhand deleted the revert-6777-blockbase-allow-jetpack-fonts branch December 20, 2022 09:24
@simison simison mentioned this pull request Dec 20, 2022
Merged
@pbking
Copy link
Contributor

pbking commented Jan 18, 2023

I have discovered that the presence of "provider": "blockbase-fonts" is what has caused them to go missing. I'm not sure WHY that has caused them to go missing, and to only go missing for CHILD fonts. But I'm pretty sure that we can re-introduce the original change (#6777) to allow Blockbase and Jetpack to work together as expected.

@pbking pbking mentioned this pull request Jan 19, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@madhusudhand @pbking