Skip to content

Fix is_decoupled() warning when frontend is running on different port #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alecgeatches merged 5 commits into from
Aug 4, 2022
Merged

Fix is_decoupled() warning when frontend is running on different port #57

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
23de7f5
Include port in is_decoupled() check
alecgeatches Aug 1, 2022
b8b355f
Fix copy-paste error in backend port
alecgeatches Aug 1, 2022
6b8cc4a
Fix PHPCS warnings
alecgeatches Aug 1, 2022
1cdaa23
Remove unnecessary wp-phpunit dependency
alecgeatches Aug 3, 2022
1125d5b
Fix tests by specifying WordPress version
alecgeatches Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix PHPCS warnings
  • Loading branch information
@alecgeatches
alecgeatches committed Aug 1, 2022
commit 6b8cc4a8f8e19539380ea23af6de1a6cc09d6fbe
8 changes: 4 additions & 4 deletions admin/admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
* @return bool
*/
function is_decoupled() {
$frontend_url = wp_parse_url( home_url(), PHP_URL_HOST );
$frontend_url = wp_parse_url( home_url(), PHP_URL_HOST );
$frontend_port = wp_parse_url( home_url(), PHP_URL_PORT );
$frontend = $frontend_url . ( $frontend_port ? ':' . $frontend_port : '' );
$frontend = $frontend_url . ( $frontend_port ? ':' . $frontend_port : '' );

$backend_url = wp_parse_url( site_url(), PHP_URL_HOST );
$backend_url = wp_parse_url( site_url(), PHP_URL_HOST );
$backend_port = wp_parse_url( site_url(), PHP_URL_PORT );
$backend = $backend_url . ( $backend_port ? ':' . $backend_port : '' );
$backend = $backend_url . ( $backend_port ? ':' . $backend_port : '' );

return $frontend !== $backend;
}
Expand Down