Stats: disable state persistence for stats list items. #10322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmyc
added
the
[Feature] Stats
Contributor
|
Test live: https://calypso.live/?branch=fix/stats/state |
Member
|
Not sure if it's related to this change or not, but if I do a Otherwise, this seems to work ok. |
jblz
approved these changes
Dec 29, 2016
Contributor
Author
|
closing in favor of #10326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is based on a somewhat informed hunch between some investigating that @jblz and I have done in regards to #9529
While attempting to calculate the size of the indexDb instance, Jeff was hitting some oddness around the
statsStreakpersisted data. In this branch, I have disabled the serialization of the stats list items to see if this might be a possible fix.To Test
Open a site stats insights page, and ensure the "Post Trends" data still loads as expected