Skip to content

Conversation

@StevenDufresne
Copy link
Contributor

@StevenDufresne StevenDufresne commented Oct 20, 2025

Related to: DOTCOM-14984

Proposed Changes

Remove the "Reader" text until the desktop size preset.

It currently grows:
Screen Recording on 2025-10-20 at 01-30-30

Screenshot

Before After
Screen Recording on 2025-10-20 at 01-27-56 Screen Recording on 2025-10-21 at 07-57-19

|

Why not display it earlier?

I don't know, I just tied into the desktop size because that's when the rest of the menu appears.

I feel having the same menu in portrait and landscape makes more sense than it appearing.

Testing Instructions

  • Load v2 in mobile, and table
  • Expect to not see the icon.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@StevenDufresne StevenDufresne requested a review from a team as a code owner October 20, 2025 04:33
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 20, 2025
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

@StevenDufresne StevenDufresne requested a review from a team October 20, 2025 04:34
@matticbot
Copy link
Contributor

matticbot commented Oct 20, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/hd-align-remove-reader-icon-on-mobile on your sandbox.

@jasmussen
Copy link
Member

Thanks for the ping. Seems fine as a quick fix. However, two followups come to mind:

  1. We should address the issue with the icon button, so the icon never scales like that. There must be a flex-shrink property in place. CC: @aduth @mirka in case they have instincts.
  2. Can the Reader collapse to just the eyeglasses icon on mobile, instead of disappearing entirely?

@StevenDufresne
Copy link
Contributor Author

Can the Reader collapse to just the eyeglasses icon on mobile, instead of disappearing entirely?

Yep, we can render the icon instead!

@mirka
Copy link
Member

mirka commented Oct 20, 2025

  1. We should address the issue with the icon button, so the icon never scales like that. There must be a flex-shrink property in place.

Proposed upstream fix at WordPress/gutenberg#72474 👍

@StevenDufresne StevenDufresne changed the title Hosting Dashboard: Remove the reader icon until desktop. Hosting Dashboard: Remove the reader text until desktop. Oct 20, 2025
@StevenDufresne StevenDufresne merged commit 6dc7389 into trunk Oct 20, 2025
14 checks passed
@StevenDufresne StevenDufresne deleted the fix/hd-align-remove-reader-icon-on-mobile branch October 20, 2025 23:52
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 20, 2025
@lucasmendes-design
Copy link

Related #106542 (comment)

cc: @fushar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants