Stats: Fix archive list showing incorrect totals#108578
Draft
Conversation
The Archive tab in the top posts module was showing different totals than the view details page because they were using different max values for the backend API. The module card used max=10 while the summary page used max=0 (all results). This fixes the issue by setting max=50 in both places to ensure consistent results.
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes STATS-211
Proposed Changes
max: 50for the stats query in both the traffic page module and the summary/details pageWhy are these changes being made?
The Archive tab in the top posts module was showing different totals than the view details page because they were using different
maxvalues for the backend API:max: 10max: 0(which fetches all results)This caused a mismatch in the displayed totals. By setting
max: 50in both places, we ensure consistent results between the module card and the view details page.Testing Instructions
Pre-merge Checklist