Skip to content

Purchases: Rename constants for upgrade actions to be more consistent #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gziolo merged 22 commits into from
Dec 8, 2015
Merged

Purchases: Rename constants for upgrade actions to be more consistent #1253

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8255f5c
Domains: Order upgrade action constants alphabetically
stephanethomas Dec 3, 2015
b32b799
Domains: Rename constant for resent ICANN verification action to be m…
stephanethomas Dec 3, 2015
97ebc28
Checkout: Rename constant for add cart item action to be more consistent
stephanethomas Dec 3, 2015
56addeb
Checkout: Rename constant for remove cart item action to be more cons…
stephanethomas Dec 3, 2015
417c357
Checkout: Rename constant for apply cart coupon action to be more con…
stephanethomas Dec 3, 2015
c685e45
Checkout: Rename constant for close cart popup action to be more cons…
stephanethomas Dec 3, 2015
2d10394
Checkout: Rename constant for open cart popup action to be more consi…
stephanethomas Dec 3, 2015
32ceb33
Checkout: Rename constant for add privacy protection to cart action t…
stephanethomas Dec 3, 2015
51a8238
Checkout: Rename constant for remove privacy protection to cart actio…
stephanethomas Dec 3, 2015
1d75a89
Purchases: Remove unused constant for receive site upgrades action
stephanethomas Dec 3, 2015
8b29211
Domains: Rename constant for add DNS action to be more consistent
stephanethomas Dec 3, 2015
b34434d
Domains: Rename constant for delete DNS action to be more consistent
stephanethomas Dec 3, 2015
7be02b9
Domains: Rename constants for fetch DNS actions to be more consistent
stephanethomas Dec 3, 2015
cc9478b
Domains: Rename constant for enable domain locking action to be more …
stephanethomas Dec 3, 2015
94b5cad
Domains: Rename constant for enable privacy protection action to be m…
stephanethomas Dec 3, 2015
ec4d573
Domains: Rename constants for fetch Google Apps users actions to be m…
stephanethomas Dec 3, 2015
9eb5cea
Purchases: Rename constants for cancel privacy protection action to b…
stephanethomas Dec 3, 2015
f240960
Checkout: Rename constant for set transaction step action to be more …
stephanethomas Dec 3, 2015
150dde3
Checkout: Rename constant for reset transaction action to be more con…
stephanethomas Dec 3, 2015
40df408
Checkout: Rename constant for set domain details in transaction actio…
stephanethomas Dec 3, 2015
4430a6f
Checkout: Rename constant for set new credit card details in transact…
stephanethomas Dec 3, 2015
451f44a
Checkout: Rename constant for set payment in transaction action to be…
stephanethomas Dec 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Domains: Rename constant for enable domain locking action to be more … 
…consistent
  • Loading branch information
@stephanethomas
stephanethomas committed Dec 3, 2015
commit cc9478be261b695adab52a4f06899a75c83f0f9a
2 changes: 1 addition & 1 deletion client/lib/domains/wapi-domain-info/reducer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function reducer( state, payload ) {
needsUpdate: true
} );

case UpgradesActionTypes.DOMAIN_ENABLE_LOCKING_COMPLETED:
case UpgradesActionTypes.DOMAIN_LOCKING_ENABLE_COMPLETED:
return updateDomainState( state, action.domainName, {
data: Object.assign( {}, state[ action.domainName ].data, {
locked: true,
Expand Down
2 changes: 1 addition & 1 deletion client/lib/upgrades/actions/domain-management.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ function enableDomainLocking( domainName, onComplete ) {
}

Dispatcher.handleServerAction( {
type: ActionTypes.DOMAIN_ENABLE_LOCKING_COMPLETED,
type: ActionTypes.DOMAIN_LOCKING_ENABLE_COMPLETED,
domainName
} );

Expand Down
2 changes: 1 addition & 1 deletion client/lib/upgrades/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ module.exports.action = keyMirror( {
DNS_DELETE: null,
DNS_FETCH: null,
DNS_FETCH_COMPLETED: null,
DOMAIN_ENABLE_LOCKING_COMPLETED: null,
DOMAIN_ENABLE_PRIVACY_PROTECTION_COMPLETED: null,
DOMAIN_LOCKING_ENABLE_COMPLETED: null,
DOMAIN_TRANSFER_ACCEPT_COMPLETED: null,
DOMAIN_TRANSFER_CODE_REQUEST_COMPLETED: null,
DOMAIN_TRANSFER_DECLINE_COMPLETED: null,
Expand Down