Reader: improve performance of conversations #21468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samouri
changed the base branch from
master
to
add/framework/create-cached-selector
designsimply
added
[Status] In Progress
[Feature] Reader
samouri
force-pushed
the
update/conversations-perf
branch
2 times, most recently
from
385b915 to
ff11586
Compare
samouri
changed the base branch from
add/framework/create-cached-selector
to
master
samouri
force-pushed
the
update/conversations-perf
branch
from
ff11586 to
2ebbc76
Compare
samouri
added
[Status] Needs Review
samouri
added
[Status] In Progress
and removed
[Status] Needs Review
Contributor
|
Nice one @samouri! I'm seeing some failing tests for the
|
Contributor
Author
|
The failing test raises an interesting question: what should treeSelect do when dependencies are undefined? |
samouri
added
[Status] Needs Review
Contributor
Author
samouri
added
[Status] Blocked / Hold
and removed
[Status] Needs Review
Contributor
Author
|
blocked on merge of: #21625 |
samouri
force-pushed
the
update/conversations-perf
branch
from
5b7b7d0 to
24adbd6
Compare
Contributor
|
@samouri i'd love to land this. Could you take a look at the failed tests? |
samouri
force-pushed
the
update/conversations-perf
branch
from
24adbd6 to
ecac717
Compare
Contributor
Author
|
Failed test should be fixed by #21625 which landed yesterday! |
samouri
added
[Status] Needs Review
sirreal
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Conversations are dependent upon a single posts's comments and not the entire collection of comments. Therefore the current
createSelectorapproach is less effective than it could be. This PR improves the performance by utilizing treeSelector.I tested for fewer re-renders by using this unmerged performance tool.
below is the result of loading conversations and clicking "more comments" a couple times.
before
after
summary of results
By using
treeSelectinstead ofcreateSelectorI was able to get the wasted render count down from ~351 to 8. These numbers were just after a few second after loading -- I'm sure it would get wayy more drastic if i used conversations for much longer.