Move the babel-core bridge package to devDependencies #26086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Status] Needs Review
Contributor
jsnajdr
force-pushed
the
remove/babel-core-bridge
branch
from
07b326e to
32ab9de
Compare
blowery
approved these changes
Jul 16, 2018
Contributor
blowery
left a comment
blowery
left a comment
There was a problem hiding this comment.
LGTM assuming tests pass
Member
Author
|
Hmm, it turns out it's required by |
After updating the Babel cache key creator to use `@babel/core`, the compatibility bridge is used only by Jest and therefore can be a dev dependency.
jsnajdr
force-pushed
the
remove/babel-core-bridge
branch
from
32ab9de to
c6e804a
Compare
jsnajdr
changed the title
Contributor
|
ah yes jestjs/jest#4918 |
Contributor
|
still approved :) |
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating the Babel cache key creator to use
@babel/core, the compatibility bridge is not used by anything else and can be removed.Edit: repurposed to moving the bridge to
devDependenciesas it's used only by Jest now.