Add a wrapper for premium blocks #33723
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
scruffian
commented
Jun 7, 2019
| padding: 10px; | ||
| } | ||
|
|
||
| .upgrade-nudge { |
Member
Author
There was a problem hiding this comment.
The styles are duplicated from the component in Calypso :(
scruffian
commented
Jun 7, 2019
| @@ -0,0 +1,28 @@ | |||
| /** | |||
Member
Author
There was a problem hiding this comment.
This is essentially a duplicate of https://wpcalypso.wordpress.com/devdocs/blocks/upgrade-nudge
scruffian
commented
Jun 7, 2019
| { translate( 'To gain access to this block.' ) } | ||
| </span> | ||
| </div> | ||
| <button className="upgrade-nudge__button">{ translate( 'Upgrade' ) }</button> |
Member
Author
There was a problem hiding this comment.
We should reuse the component at the very least.
scruffian
commented
Jun 7, 2019
| if ( name === 'jetpack/simple-payments' ) { | ||
| return { | ||
| ...settings, | ||
| edit: wrapPremiumBlocks( settings.edit ), |
Member
Author
There was a problem hiding this comment.
Wrapping the block in another component seems like an elegant way of creating a consistent experience for all premium blocks.
Contributor
There was a problem hiding this comment.
Yep, I like that approach 👍
Contributor
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
5 tasks
Member
|
Merged this work in Automattic/jetpack#12823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Testing instructions
This is tricky to test