Skip to content

Gutenboarding: Squash type errors #38401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sirreal merged 6 commits into from
Dec 17, 2019
Merged

Gutenboarding: Squash type errors #38401

sirreal merged 6 commits into from
Dec 17, 2019

Conversation

@sirreal
Copy link
Member

@sirreal sirreal commented Dec 13, 2019

Changes proposed in this Pull Request

  • Add types to TemplateSelectorControls via JSDoc
  • Squash/silence the rest of the type errors.

Required for #37945

Testing instructions

  • No regressions at /gutenboarding
  • npm run typecheck -- --project client/landing/gutenboarding - no errors 🎉

@sirreal sirreal added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Task labels Dec 13, 2019
@sirreal sirreal requested a review from a team December 13, 2019 10:51
@sirreal sirreal requested a review from a team as a code owner December 13, 2019 10:51
@sirreal sirreal self-assigned this Dec 13, 2019
@matticbot
Copy link
Contributor

matticbot commented Dec 13, 2019

Test live: https://calypso.live/?branch=gutenboarding/fix-type-errors

@sirreal sirreal mentioned this pull request Dec 13, 2019
Merged
@matticbot
Copy link
Contributor

matticbot commented Dec 13, 2019 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~5 bytes added 📈 [gzipped])

Details 
name                 parsed_size           gzip_size
entry-gutenboarding        -50 B  (-0.0%)       +5 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirreal sirreal mentioned this pull request Dec 13, 2019
Closed
ockham
ockham reviewed Dec 13, 2019
View reviewed changes
ockham
ockham reviewed Dec 13, 2019
View reviewed changes
ockham
ockham reviewed Dec 13, 2019
View reviewed changes
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for taking this on! 👏

I have one thing that I'm a bit unsure about (see this comment on my PR). I'd like to hear your thoughts on that before we settle on either fix 😄

@sirreal sirreal force-pushed the gutenboarding/fix-type-errors branch from 3f75d76 to da18ac7 Compare December 16, 2019 15:34
@ockham ockham force-pushed the gutenboarding/fix-type-errors branch from da18ac7 to af5ba7d Compare December 17, 2019 10:32
@sirreal
Copy link
Member Author

sirreal commented Dec 17, 2019 •
edited
Loading

#38466 Fixes an additional type issue with asset modules handled by the file-loader

@sirreal sirreal added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 17, 2019
@sirreal sirreal removed the request for review from a team December 17, 2019 10:54
ockham
ockham approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think I'm fine with merging this. Let's maybe add a comment to the queryObject cast, mentioning that we think the issue should probably fixed upstream (per our discussion here).

@sirreal sirreal added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 17, 2019
@sirreal sirreal merged commit 2eb3208 into master Dec 17, 2019
@sirreal sirreal deleted the gutenboarding/fix-type-errors branch December 17, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ockham ockham ockham approved these changes

Assignees

@sirreal sirreal

Labels

[Type] Task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sirreal @matticbot @ockham