-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(deps): update wordpress monorepo #38554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fab887f to
ab25cdb
Compare
|
The The reason is WordPress/gutenberg@995aa3a#diff-1c24406914c18d0668eb1f64880d4144L28. I'll push a fix to this PR. |
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description. |
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Webpack Runtime (~59 bytes removed 📉 [gzipped]) DetailsWebpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded. App Entrypoints (~3275 bytes added 📈 [gzipped]) DetailsCommon code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~29877 bytes removed 📉 [gzipped]) DetailsSections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~2792 bytes removed 📉 [gzipped]) DetailsReact components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
6792f34 to
2b76cdd
Compare
|
Rebased and updated the locks, FSE lock was unchanged and failing the tests. |
|
Looks like something in the WordPress jest preset is off in the FSE test: |
|
@noahtallen @vindl will you folks look into that FSE error? |
|
There was a bug in the package. I've pulled in the patch version upgrade and expect things to be working as expected now. |
sirreal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing and this is working well in development in my smoke testing 👍
vindl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Dotcom FSE and didn't notice any blockers. 👍
|
This is blocked on WordPress/gutenberg#19535. There is a regression only present in production mode builds where imported stylesheets are not included. This is an issue with the |
c8ae564 to
00a4d60
Compare
|
Rebased. |
|
I've pushed b4f0039 as a workaround for the regression. It avoids tree-shaking by importing the affected CSS file from SASS (where no tree-shaking occurs) instead of via JavaScript import. That change can be reverted when the patched package is released. |
sirreal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to work well now.
Workaround for regression in package. See: WordPress/gutenberg#19535
b4f0039 to
e1f9673
Compare
|
Rebased, attempting to fix repeated e2e failures. |
This PR contains the following updates:
3.7.0->3.8.01.0.0->1.1.03.3.0->3.4.02.10.0->2.11.06.8.0->6.9.08.4.0->8.5.03.8.0->3.9.02.8.0->2.9.04.10.0->4.11.01.4.0->1.5.03.9.0->3.10.09.8.0->9.9.02.9.0->2.10.01.10.0->1.11.05.2.0->5.3.01.9.0->1.10.03.8.0->3.9.02.8.0->2.9.03.8.0->3.9.06.0.0->6.1.01.4.0->1.5.02.8.2->2.9.02.9.0->2.10.0Release Notes
WordPress/gutenberg
v3.8.0Compare Source
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!".👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
Newsflash: Renovate has joined WhiteSource, and is now free for all use. Learn more or view updated terms and privacy policies.